You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2019/12/04 20:17:00 UTC

[jira] [Updated] (HBASE-23368) Optimize Debug Logging of ClientZKSyncer

     [ https://issues.apache.org/jira/browse/HBASE-23368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mollitor updated HBASE-23368:
-----------------------------------
    Attachment: HBASE-23368.1.patch

> Optimize Debug Logging of ClientZKSyncer
> ----------------------------------------
>
>                 Key: HBASE-23368
>                 URL: https://issues.apache.org/jira/browse/HBASE-23368
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HBASE-23368.1.patch
>
>
> In particular, this caught my eye:
> {code:java|title=ClientZKSyncer.java}
>     // set meta znodes for client ZK
>     Collection<String> nodes = getNodesToWatch();
>     LOG.debug("Znodes to watch: " + nodes);
> {code}
> There are no guards around this debug statement, so the entire list of nodes is always turned into a string and passed to the {{debug}} method,... and then promptly discarded if debug is not enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)