[GitHub] groovy pull request: make private methods static when they are pur...

[oreissig <gi...@git.apache.org>]

GitHub user oreissig opened a pull request:

    https://github.com/apache/groovy/pull/261

    make private methods static when they are pure functions

    Just a minor thing: Most AST transformations are stateless and only pass data via arguments, which allows to treat a lot of their helper methods as static functions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oreissig/groovy use-static-where-possible

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #261
    
----
commit d51cd132195dc9a56500240d7d2285ef300a7622
Author: oreissig <or...@gmail.com>
Date:   2016-02-12T16:51:36Z

    make private methods static when they are pure functions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request: make private methods static when they are pur...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---