You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/05 10:06:43 UTC

[GitHub] [spark] Ngone51 commented on pull request #32401: [SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file

Ngone51 commented on pull request #32401:
URL: https://github.com/apache/spark/pull/32401#issuecomment-873985519


   > so what did the benchmarking numbers look like? Was there an average hit across or mostly just noise?
   
   @tgravescs Our internal benchmark runs between the baseline (master) and target (master + checksum changes). It measures the end-to-end execution time of TPC-DS queries. So the numbers are actually the execution time of queries. And from the result, it mostly just noise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org