[GitHub] [lucene] iverase commented on pull request #7: LUCENE-9820: Separate logic for reading the BKD index from logic to intersecting it

[GitBox <gi...@apache.org>]

iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-935815211


   I run another iteration on this patch as I was noticing that this version was consistently slower than the current version. I think the issue was the way we were handling adding all when a cell needs to be added through the fast path. In the current version we navigate down the tree without having to update the min/max packed bytes.
   
   Therefore I have done a small change where now we accept to call the methods visit* from any node of the tree:
   
   ```
       /** Visit all the docs below the current node. */
       void visitDocIDs(IntersectVisitor visitor) throws IOException;
   
       /** Visit all the docs and values below the current node. */
       void visitDocValues(IntersectVisitor visitor) throws IOException;
   ```
   
   This seems to get us in the same performance. What I am worry about now is the following method:
   
   ```
    /** Return the number of points below the current node. */
       long size();
   ```
   
   Currently we might return a size that is bigger that the number of points. Should we modified the method to return the exact number of points all the time or change the contract of the method?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org