You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2014/08/01 22:12:25 UTC
Review Request 24192: Text splitter should also consider NCHAR and NVARCHAR
fields
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24192/
-----------------------------------------------------------
Review request for Sqoop.
Summary (updated)
-----------------
Text splitter should also consider NCHAR and NVARCHAR fields
Bugs: SQOOP-1412
https://issues.apache.org/jira/browse/SQOOP-1412
Repository: sqoop-trunk
Description (updated)
-------
Added NCHAR and NVARCHAR fields. Splitting on text warning still applies to this given the DB collation can cause partial/duplicate record imports)
Diffs (updated)
-----
src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 02f3d62
Diff: https://reviews.apache.org/r/24192/diff/
Testing (updated)
-------
Tested with Sql Server 2014
Thanks,
Venkat Ranganathan
Re: Review Request 24192: Text splitter should also consider NCHAR and
NVARCHAR fields
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24192/#review49436
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Aug. 1, 2014, 8:12 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24192/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 8:12 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1412
> https://issues.apache.org/jira/browse/SQOOP-1412
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Added NCHAR and NVARCHAR fields. Splitting on text warning still applies to this given the DB collation can cause partial/duplicate record imports)
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 02f3d62
>
> Diff: https://reviews.apache.org/r/24192/diff/
>
>
> Testing
> -------
>
> Tested with Sql Server 2014
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request 24192: Text splitter should also consider NCHAR and
NVARCHAR fields
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24192/#review49434
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Aug. 1, 2014, 8:12 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24192/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 8:12 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1412
> https://issues.apache.org/jira/browse/SQOOP-1412
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Added NCHAR and NVARCHAR fields. Splitting on text warning still applies to this given the DB collation can cause partial/duplicate record imports)
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 02f3d62
>
> Diff: https://reviews.apache.org/r/24192/diff/
>
>
> Testing
> -------
>
> Tested with Sql Server 2014
>
>
> Thanks,
>
> Venkat Ranganathan
>
>