[GitHub] [qpid-jms] gemmellr commented on pull request #43: QPIDJMS-548: support taking principle and credentials from context

[GitBox <gi...@apache.org>]

gemmellr commented on pull request #43:
URL: https://github.com/apache/qpid-jms/pull/43#issuecomment-921804323


   Well again, there are ways that dont require putting them in the URL, including the very one you used to implement the change under the covers.
   
   If you are saying that the factory.createConnection(user, pass) method doesnt work and this does, then that would likely be a bug that should be investigated and fixed, but it is not a good reason to add this hack, which I still dont intend to.
   
   For what its worth, the createConnection(user, pass) method is tested, and it operates by passing the credentials to the client innards in the same field as setting them on the factory does, since both are transferred to an intermediate object from where they actually get used, its actually the more explicitly set of the two, so I dont immediately see how this could make any difference at all to what the client does.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org