[jira] [Commented] (FLINK-9168) Pulsar Sink Connector

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468982#comment-16468982 ] 

ASF GitHub Bot commented on FLINK-9168:
---------------------------------------

Github user pluppens commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5845#discussion_r187084563
  
    --- Diff: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/PulsarProduceMode.java ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.pulsar;
    +
    +/**
    + * The supported producing modes of operation for flink's pulsar producer.
    + */
    +public enum PulsarProduceMode {
    +
    +	/**
    +	 * Any produce failures will be ignored hence there could be data loss.
    +	 */
    +	AT_MOST_ONCE,
    +
    +	/**
    +	 * The producer will ensure that all the events are persisted in pulsar.
    +	 * There could be duplicate events written though.
    +	 */
    +	AT_LEAST_ONE,
    --- End diff --
    
    Is this is intentional? `AT_LEAST_ONCE` seems more appropriate?


> Pulsar Sink Connector
> ---------------------
>
>                 Key: FLINK-9168
>                 URL: https://issues.apache.org/jira/browse/FLINK-9168
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>    Affects Versions: 1.6.0
>            Reporter: Zongyang Xiao
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> Flink does not provide a sink connector for Pulsar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)