You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/04/09 04:14:18 UTC

Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45974/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-15787
    https://issues.apache.org/jira/browse/AMBARI-15787


Repository: ambari


Description
-------

For SERVER alerts, change display_name to the text from description field, as it's used for label of the config field.


Diffs
-----

  ambari-server/src/main/resources/alerts.json 3b6ebbb 

Diff: https://reviews.apache.org/r/45974/diff/


Testing
-------


Thanks,

Zhe (Joe) Wang


Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45974/#review128099
-----------------------------------------------------------




ambari-server/src/main/resources/alerts.json (line 43)
<https://reviews.apache.org/r/45974/#comment191483>

    The display name is how this value should be displayed in the web client; not the description. 
    
    For example, this could easily have been something like "Warning Response Time" instead of just "Warning". I'm fine changing this to something similar, but it should not be a duplicate of the description field.


- Jonathan Hurley


On April 8, 2016, 10:14 p.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45974/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15787
>     https://issues.apache.org/jira/browse/AMBARI-15787
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For SERVER alerts, change display_name to the text from description field, as it's used for label of the config field.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/alerts.json 3b6ebbb 
> 
> Diff: https://reviews.apache.org/r/45974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>


Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45974/#review128149
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On April 11, 2016, 12:29 p.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45974/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 12:29 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15787
>     https://issues.apache.org/jira/browse/AMBARI-15787
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For SERVER alerts, change display_name to the text from description field, as it's used for label of the config field.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/alerts.json 3b6ebbb 
> 
> Diff: https://reviews.apache.org/r/45974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>


Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text with more info

Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45974/
-----------------------------------------------------------

(Updated April 11, 2016, 9:47 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and Yusaku Sako.


Summary (updated)
-----------------

AMBARI-15787 Server Alert definitions: Change display_name to the text with more info


Bugs: AMBARI-15787
    https://issues.apache.org/jira/browse/AMBARI-15787


Repository: ambari


Description
-------

For SERVER alerts, change display_name to the text from description field, as it's used for label of the config field.


Diffs
-----

  ambari-server/src/main/resources/alerts.json 3b6ebbb 

Diff: https://reviews.apache.org/r/45974/diff/


Testing
-------

All alert unit test passed.

mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false


Thanks,

Zhe (Joe) Wang


Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45974/
-----------------------------------------------------------

(Updated April 11, 2016, 5:05 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-15787
    https://issues.apache.org/jira/browse/AMBARI-15787


Repository: ambari


Description
-------

For SERVER alerts, change display_name to the text from description field, as it's used for label of the config field.


Diffs
-----

  ambari-server/src/main/resources/alerts.json 3b6ebbb 

Diff: https://reviews.apache.org/r/45974/diff/


Testing (updated)
-------

All alert unit test passed.

mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false


Thanks,

Zhe (Joe) Wang


Re: Review Request 45974: AMBARI-15787 Server Alert definitions: Change display_name to the text from description

Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45974/
-----------------------------------------------------------

(Updated April 11, 2016, 4:29 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-15787
    https://issues.apache.org/jira/browse/AMBARI-15787


Repository: ambari


Description
-------

For SERVER alerts, change display_name to the text from description field, as it's used for label of the config field.


Diffs (updated)
-----

  ambari-server/src/main/resources/alerts.json 3b6ebbb 

Diff: https://reviews.apache.org/r/45974/diff/


Testing
-------


Thanks,

Zhe (Joe) Wang