[jira] [Comment Edited] (MNG-8464) [Regression] Maven 4-rc-2 breaks Maven ShrinkWrap Resolvers

["Tamas Cservenak (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907576#comment-17907576 ] 

Tamas Cservenak edited comment on MNG-8464 at 12/21/24 12:13 PM:
-----------------------------------------------------------------

Lenny, just to clear up things:
* consumer POM as is, is _only about publishing_, so remote repository is to contain consumer POM
* as I see, the referenced PR is totally wrong (or one could say, it make Shrinkwrap dependent on an "implementation detail" -- that consumer POM was present in local as well). Again, this was _never_ the promise of "consumer POM" feature, that is about _publishing only_.
* since Maven3.0 it is "well known things" that no code (plugin, extension, whatever) should reach directly to local repository https://maven.apache.org/repositories/local.html as it caused havoc back then, and was VERY hard to fix in Maven3, and even today it causes issues, as we saw with Maven3.9, that despite having "split repo feature" cannot 100% support it, exactly due plugins/extensions/various code containing assumptions about "Maven internals".
* unsure how did you deduce all these statements... can you elaborate?


was (Author: cstamas):
Lenny, just to clear up things:
* consumer POM as is, is _only about publishing_, so remote repository is to contain consumer POM
* as I see, the referenced PR is totally wrong (or one could say, it make Shrinkwrap dependent on an "implementation detail" -- that consumer POM was present in local as well). Again, this was _never_ the promise of "consumer POM" feature, that is about _publishing only_.
* unsure how did you deduce all these statements... can you elaborate?

> [Regression] Maven 4-rc-2 breaks Maven ShrinkWrap Resolvers
> -----------------------------------------------------------
>
>                 Key: MNG-8464
>                 URL: https://issues.apache.org/jira/browse/MNG-8464
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 4.0.0-rc-2
>            Reporter: Lenny Primak
>            Priority: Critical
>
> This is a regression from rc-1. Caused by MNG-8393 and [https://github.com/apache/maven/pull/1963]
> In rc-1 and prior, project-local-repo contained consumer pom, but now it contains a build pom {*}only{*}, which breaks the resolvers.
> Consumer POM is needed for shrinkwrap resolvers to work correctly.
> See [https://github.com/shrinkwrap/resolver/pull/369] and https://github.com/shrinkwrap/resolver/blob/0d3d07fcd46bdfa38fb59025ab3da259d033ffcd/maven/impl-maven/src/main/java/org/jboss/shrinkwrap/resolver/impl/maven/MavenWorkingSessionImpl.java#L200
> {code:java}
> Caused by: java.lang.reflect.InvocationTargetException
> 	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> 	at org.jboss.arquillian.container.test.impl.client.deployment.AnnotationDeploymentScenarioGenerator.invoke(AnnotationDeploymentScenarioGenerator.java:164)
> 	... 34 more
> Caused by: org.jboss.shrinkwrap.resolver.api.InvalidConfigurationFileException: Found 1 problems while building POM model from /Users/lprimak/dev/flowlogix/target/project-local-repo/com.flowlogix/flowlogix-jee/9.x-SNAPSHOT/flowlogix-jee-9.x-SNAPSHOT.pom
> 1/ [FATAL] Non-resolvable parent POM for com.flowlogix:flowlogix-jee:9.x-SNAPSHOT: Failed to resolve POM for com.flowlogix:jakarta-ee:9.x-SNAPSHOT due to The following artifacts could not be resolved: com.flowlogix:jakarta-ee:pom:9.x-SNAPSHOT (absent): Could not find artifact com.flowlogix:jakarta-ee:pom:9.x-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ com.flowlogix:flowlogix-jee:9.x-SNAPSHOT, /Users/lprimak/dev/flowlogix/target/project-local-repo/com.flowlogix/flowlogix-jee/9.x-SNAPSHOT/flowlogix-jee-9.x-SNAPSHOT.pom
> 	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.loadPomFromFile(MavenWorkingSessionImpl.java:185)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.loadPomFromFile(MavenWorkingSessionImpl.java:152)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.processAdditionalDependencies(MavenWorkingSessionImpl.java:252)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.resolveProjectLocal(MavenWorkingSessionImpl.java:230)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.resolveProjectLocal(MavenWorkingSessionImpl.java:204)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.MavenWorkingSessionImpl.resolveDependencies(MavenWorkingSessionImpl.java:305)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.archive.packaging.WarPackagingProcessor.importBuildOutput(WarPackagingProcessor.java:112)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.archive.packaging.WarPackagingProcessor.importBuildOutput(WarPackagingProcessor.java:51)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.PomEquippedMavenImporterImpl.importBuildOutput(PomEquippedMavenImporterImpl.java:49)
> 	at org.jboss.shrinkwrap.resolver.impl.maven.archive.importer.PomEquippedMavenImporterImpl.importBuildOutput(PomEquippedMavenImporterImpl.java:44)
> 	at com.flowlogix.util.ShrinkWrapManipulator.createDeployment(ShrinkWrapManipulator.java:133)
> 	at com.flowlogix.util.ShrinkWrapManipulator.createDeployment(ShrinkWrapManipulator.java:119)
> 	at com.flowlogix.examples.ExceptionPageIT.createDeployment(ExceptionPageIT.java:228)
> 	at com.flowlogix.examples.ExceptionPageIT.createDeploymentDev(ExceptionPageIT.java:224)
> 	at com.flowlogix.examples.Deployments.createDeployment(Deployments.java:33)
> 	... 36 more {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)