You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/02 17:29:17 UTC
[GitHub] [geode] nonbinaryprogrammer opened a new pull request #6253: GEODE-9052: rename the geode-redis module (#6211)
nonbinaryprogrammer opened a new pull request #6253:
URL: https://github.com/apache/geode/pull/6253
rename the geode-redis module to geode-apis-compatible-with-redis. this
is so that this name doesn't end up in a customer-facing location that
may cause us to violate Redis's copyright
also adds acceptance test dependency on installDist task. Previously there was not an explicit dependency so tests would fail if they happened to start before the installDist task ran
(cherry picked from commit f82304bd2a9514ad622b3a1c4b51f1fe62399e3e)
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer commented on pull request #6253: GEODE-9052: rename the geode-redis module (#6211)
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer commented on pull request #6253:
URL: https://github.com/apache/geode/pull/6253#issuecomment-813535351
closed as redundant to: https://github.com/apache/geode/pull/6264
which was created for ease of resolving merge conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer closed pull request #6253: GEODE-9052: rename the geode-redis module (#6211)
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer closed pull request #6253:
URL: https://github.com/apache/geode/pull/6253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org