You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/12/02 11:18:47 UTC

[GitHub] [ignite] sk0x50 commented on a change in pull request #8406: IGNITE-13640 copy-libs plugin added.

sk0x50 commented on a change in pull request #8406:
URL: https://github.com/apache/ignite/pull/8406#discussion_r534089525



##########
File path: modules/opencensus/pom.xml
##########
@@ -116,4 +116,27 @@
             <scope>test</scope>
         </dependency>
     </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>copy-libs</id>
+                        <phase>test-compile</phase>

Review comment:
       Hello @Mmuzaf ,
   
   >why phase test-compile instead of package?
   
   Changed to `package`. Thank you!
   
   > all the opencensus libs will be available at libs directory by default, right?
   
   All libs will be placed at `libs/optional/ignite-opencensus` in the release build.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org