You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/10 16:30:42 UTC
[GitHub] [rocketmq-dashboard] charliex2 opened a new pull request #20: Update README.md
charliex2 opened a new pull request #20:
URL: https://github.com/apache/rocketmq-dashboard/pull/20
fixed small typo error
## What is the purpose of the change
fixed small type error
## Brief changelog
1. change "apacherocketmq/rocketmq-console-ng" to "apacherocketmq/rocketmq-console" in README.md;
2. change "apacherocketmq/rocketmq-console-ng:2.0.0" to "apacherocketmq/rocketmq-console:2.0.0" in README.md;
## Verifying this change
Have checked the correct image name in docker hub (https://hub.docker.com/r/apacherocketmq/rocketmq-console)
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] charliex2 edited a comment on pull request #20: Update README.md
Posted by GitBox <gi...@apache.org>.
charliex2 edited a comment on pull request #20:
URL: https://github.com/apache/rocketmq-dashboard/pull/20#issuecomment-917407873
> Hi @charliex2
> Thank you for your contribution.
> I find that [docker hub rocketmq console](https://hub.docker.com/r/apacherocketmq/rocketmq-console/tags?page=1&ordering=last_updated) don't have latest tag, so this CMD may still fail.
>
> ```
> docker run -e "JAVA_OPTS=-Drocketmq.namesrv.addr=127.0.0.1:9876 -Dcom.rocketmq.sendMessageWithVIPChannel=false" -p 8080:8080 -t apacherocketmq/rocketmq-console
> ```
>
> Could you help to remove it?
>
> Thanks.
Hi, @StyleTang ,
Have deleted the `docker run` CMD as you mentioned.
And,
I also added the newest tag (2.0.0) to the `docker pull` CMD, because it also failed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang commented on pull request #20: Update README.md
Posted by GitBox <gi...@apache.org>.
StyleTang commented on pull request #20:
URL: https://github.com/apache/rocketmq-dashboard/pull/20#issuecomment-917353788
Hi @charliex2
Thank you for your contribution.
I find that [docker hub rocketmq console](https://hub.docker.com/r/apacherocketmq/rocketmq-console/tags?page=1&ordering=last_updated) don't have latest tag, so this CMD may still fail.
```
docker run -e "JAVA_OPTS=-Drocketmq.namesrv.addr=127.0.0.1:9876 -Dcom.rocketmq.sendMessageWithVIPChannel=false" -p 8080:8080 -t apacherocketmq/rocketmq-console
```
Could you help to remove it?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] StyleTang merged pull request #20: Update README.md
Posted by GitBox <gi...@apache.org>.
StyleTang merged pull request #20:
URL: https://github.com/apache/rocketmq-dashboard/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] charliex2 commented on pull request #20: Update README.md
Posted by GitBox <gi...@apache.org>.
charliex2 commented on pull request #20:
URL: https://github.com/apache/rocketmq-dashboard/pull/20#issuecomment-917407873
> Hi @charliex2
> Thank you for your contribution.
> I find that [docker hub rocketmq console](https://hub.docker.com/r/apacherocketmq/rocketmq-console/tags?page=1&ordering=last_updated) don't have latest tag, so this CMD may still fail.
>
> ```
> docker run -e "JAVA_OPTS=-Drocketmq.namesrv.addr=127.0.0.1:9876 -Dcom.rocketmq.sendMessageWithVIPChannel=false" -p 8080:8080 -t apacherocketmq/rocketmq-console
> ```
>
> Could you help to remove it?
>
> Thanks.
Hi, @StyleTang ,
Have deleted the `docker run` CMD without tag.
And,
I also added newest tag (2.0.0) to the `docker run` CMD, because it also failed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org