You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/09/02 08:56:47 UTC
[GitHub] [incubator-doris] ccoffline opened a new pull request #4521: add version message to fe heartbeat and system page
ccoffline opened a new pull request #4521:
URL: https://github.com/apache/incubator-doris/pull/4521
## Proposed changes
This commit add git commit message of fe on the system page, just like be.
To achieve this, fe heartbeat message has now been carrying git commit message.
## Types of changes
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
- [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
This is my first public pr so plzzzzzz be gentle, thx=.=
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4521: add version message to fe heartbeat and system page
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4521:
URL: https://github.com/apache/incubator-doris/pull/4521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #4521: add version message to fe heartbeat and system page
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #4521:
URL: https://github.com/apache/incubator-doris/pull/4521#issuecomment-685745775
@ccoffline Hi, Thanks for your contribution.
> This commit adds git commit message of fe to the system page, just like be.
If we only want to show a git commit message on FE web, why do we need to add a commit message to the heartbeat?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on pull request #4521: add version message to fe heartbeat and system page
Posted by GitBox <gi...@apache.org>.
ccoffline commented on pull request #4521:
URL: https://github.com/apache/incubator-doris/pull/4521#issuecomment-686218300
> @ccoffline Hi, Thanks for your contribution.
>
> > This commit adds git commit message of fe to the system page, just like be.
>
> If we only want to show a git commit message on FE web, why do we need to add a commit message to the heartbeat?t
FE web shows status of each BE and FE by represent the message from the heartbeat.
The BE Version has been shown on the web and it is carried by the BE heartbeat.
I use the same implementation as BE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org