You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Pierre Smits (Jira)" <ji...@apache.org> on 2020/02/19 13:28:00 UTC
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang
to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040028#comment-17040028 ]
Pierre Smits commented on OFBIZ-9984:
-------------------------------------
Some vetting feedback:
{code:java}
+1 overall
____ _
/ ___| _ _ ___ ___ ___ ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
___) | |_| | (_| (_| __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 30s | Docker mode activated.
+---------------------------------------------------------------------------
| | | | Prechecks
+---------------------------------------------------------------------------
| +1 | dupname | 0m 1s | No case conflicting files found.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or
| | | | modified test files.
+---------------------------------------------------------------------------
| | | | trunk Compile Tests
+---------------------------------------------------------------------------
| +1 | compile | 21m 38s | trunk passed
| +1 | checkstyle | 12m 39s | trunk passed
| +1 | javadoc | 3m 25s | trunk passed
+---------------------------------------------------------------------------
| | | | Patch Compile Tests
+---------------------------------------------------------------------------
| +1 | compile | 5m 48s | the patch passed
| +1 | javac | 5m 48s | the patch passed
| -0 | checkstyle | 15m 51s | root: The patch generated 1 new + 17
| | | | unchanged - 0 fixed = 18 total (was 17)
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | xml | 0m 4s | The patch has no ill-formed XML file.
| +1 | javadoc | 6m 9s | the patch passed
+---------------------------------------------------------------------------
| | | | Other Tests
+---------------------------------------------------------------------------
| 0 | asflicense | 0m 50s | ASF License check generated no output?
| | | 79m 9s |
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=18.09.2 Server=18.09.2 base: /Users/nl04748/dev/test/yetus/ofbiz/OFBIZ-9984/Dockerfile |
| JIRA Issue | OFBIZ-9984 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12943854/OFBIZ-9984.patch |
{code}
> Convert OrderServices.xml mini-lang to groovyDSL
> ------------------------------------------------
>
> Key: OFBIZ-9984
> URL: https://issues.apache.org/jira/browse/OFBIZ-9984
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: Trunk
> Reporter: Julien NICOLAS
> Assignee: Gil Portenseigne
> Priority: Minor
> Labels: groovy, mini-lang
> Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some mini-lang service to groovy script.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)