You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ray Chen (JIRA)" <ji...@apache.org> on 2009/11/03 07:44:59 UTC

[jira] Created: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk

[java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-6369
                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
         Environment: AIX
            Reporter: Ray Chen


Hi All,

On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.

The java code actually invoke the native code in netif.c.

I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl() simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
But in java6 branch according to JIRA 4155, netif.c was modified and added some API for java6.

The question is why in java6 branch,  netif.c has its own implementation to get the network interface information instead of invoking the portlib code?

I think it should invoke the portlib to make the similar code in only one place.

Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774909#action_12774909 ] 

Regis Xu commented on HARMONY-6369:
-----------------------------------

sound reasonable. There is no difference in spec between java5 and java6, so I suppose the code should be the same after fixing the issue. After applied Harmony-6369.diff, the most of logic is the same,  except code format is different and some check is ignored, for example:
    hysock_get_network_interfaces(&networkInterfaceArray,preferIPv4Stack(env));
the return value should be checked.

> [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6369
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>         Attachments: Harmony-6369.diff
>
>
> Hi All,
> On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.
> The java code actually invoke the native code in netif.c.
> I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl() simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
> But in java6 branch according to JIRA 4155, netif.c was modified and added some API for java6.
> The question is why in java6 branch,  netif.c has its own implementation to get the network interface information instead of invoking the portlib code?
> I think it should invoke the portlib to make the similar code in only one place.
> Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775245#action_12775245 ] 

Regis Xu commented on HARMONY-6369:
-----------------------------------

Hi Ray,

You can raise a new JIRA for the issue you mentioned.

And also fix applied at r834296, please verify if it was applied as you expected.



> [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6369
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>             Fix For: 5.0M12
>
>         Attachments: Harmony-6369.diff
>
>
> Hi All,
> On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.
> The java code actually invoke the native code in netif.c.
> I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl() simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
> But in java6 branch according to JIRA 4155, netif.c was modified and added some API for java6.
> The question is why in java6 branch,  netif.c has its own implementation to get the network interface information instead of invoking the portlib code?
> I think it should invoke the portlib to make the similar code in only one place.
> Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk

Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774915#action_12774915 ] 

Ray Chen commented on HARMONY-6369:
-----------------------------------

Hi Regis,
Yes, I agree. And one more thing, if this replacement applied, the network
interface name seems not as same as RI on windows platform. I think it is a
bug which also exists in trunk(java 5) code.




-- 
Regards,

Ray Chen


> [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6369
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>         Attachments: Harmony-6369.diff
>
>
> Hi All,
> On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.
> The java code actually invoke the native code in netif.c.
> I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl() simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
> But in java6 branch according to JIRA 4155, netif.c was modified and added some API for java6.
> The question is why in java6 branch,  netif.c has its own implementation to get the network interface information instead of invoking the portlib code?
> I think it should invoke the portlib to make the similar code in only one place.
> Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu resolved HARMONY-6369.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M12
         Assignee: Regis Xu

> [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6369
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>            Assignee: Regis Xu
>             Fix For: 5.0M12
>
>         Attachments: Harmony-6369.diff
>
>
> Hi All,
> On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.
> The java code actually invoke the native code in netif.c.
> I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl() simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
> But in java6 branch according to JIRA 4155, netif.c was modified and added some API for java6.
> The question is why in java6 branch,  netif.c has its own implementation to get the network interface information instead of invoking the portlib code?
> I think it should invoke the portlib to make the similar code in only one place.
> Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk

Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ray Chen closed HARMONY-6369.
-----------------------------


Patch verified. I will raise another JIRA for the what I mentioned.

Thanks, Regis!

> [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6369
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>            Assignee: Regis Xu
>             Fix For: 5.0M12
>
>         Attachments: Harmony-6369.diff
>
>
> Hi All,
> On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.
> The java code actually invoke the native code in netif.c.
> I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl() simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
> But in java6 branch according to JIRA 4155, netif.c was modified and added some API for java6.
> The question is why in java6 branch,  netif.c has its own implementation to get the network interface information instead of invoking the portlib code?
> I think it should invoke the portlib to make the similar code in only one place.
> Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk

Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ray Chen updated HARMONY-6369:
------------------------------

    Attachment: Harmony-6369.diff

This patch replace the code with portlib call instead of its own implementation.


Any comments?

> [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6369
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>         Attachments: Harmony-6369.diff
>
>
> Hi All,
> On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.
> The java code actually invoke the native code in netif.c.
> I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl() simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
> But in java6 branch according to JIRA 4155, netif.c was modified and added some API for java6.
> The question is why in java6 branch,  netif.c has its own implementation to get the network interface information instead of invoking the portlib code?
> I think it should invoke the portlib to make the similar code in only one place.
> Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.