You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "bkietz (via GitHub)" <gi...@apache.org> on 2023/09/06 16:24:23 UTC

[GitHub] [arrow] bkietz commented on a diff in pull request #37588: GH-37587: [C++] Move integration machinery into its own directory and namespace

bkietz commented on code in PR #37588:
URL: https://github.com/apache/arrow/pull/37588#discussion_r1317538460


##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -836,12 +838,15 @@ add_subdirectory(tensor)
 add_subdirectory(util)
 add_subdirectory(vendored)
 
-if(ARROW_CSV)
-  add_subdirectory(csv)
+if(ARROW_BUILD_INTEGRATION OR ARROW_BUILD_TESTS)
+  # We build tests for the JSON integration machinery even if integration
+  # is enabled, to ensure it's exercised in more builds than just the

Review Comment:
   ```suggestion
     # is not enabled, to ensure it's exercised in more builds than just the
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org