You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/07/23 01:47:58 UTC
[GitHub] [incubator-dolphinscheduler] peilongwu opened a new pull request #3283: Merge support ssh command
peilongwu opened a new pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663346340
> It has a lot of cases to use many remote serves to execute some shell commands. So I think that we must to design a good method to support this feature. I want to add a new table to manage the remote servers, but many committers feel that this change is too big. They think we can manage remote servers like data sources. So I develop this feature like this.
> […](#)
> ------------------ 原始邮件 ------------------ 发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>; 发送时间: 2020年7月23日(星期四) 晚上11:09 收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>; 抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>; 主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283) Hi, I switch to your branch and check the feature. Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1] If you have any question or suggestion, welcome to put forward. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#discussion_r459394134
##########
File path: dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceService2Test.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.api.service;
+
+import org.apache.dolphinscheduler.api.ApiApplicationServer;
+import org.apache.dolphinscheduler.api.enums.Status;
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.enums.DbType;
+import org.apache.dolphinscheduler.common.enums.UserType;
+import org.apache.dolphinscheduler.dao.entity.User;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.context.junit4.SpringRunner;
+
+import java.util.Map;
+
+@RunWith(SpringRunner.class)
+@SpringBootTest(classes = ApiApplicationServer.class)
+public class DataSourceService2Test {
Review comment:
Hi,
Please add this test to root pom if you introduce this test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663316554
OK, it's very good.
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月24日(星期五) 上午10:04
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
I have checked the license of `jsch`, it is suitable for DolphinScheduler~
------------------&nbsp;原始邮件&nbsp;------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com&gt;;
发送时间:&nbsp;2020年7月24日(星期五) 上午10:02
收件人:&nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&gt;;
抄送:&nbsp;"Yichao Yang"<1048262223@qq.com&gt;;"Mention"<mention@noreply.github.com&gt;;
主题:&nbsp;Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------&amp;nbsp;原始邮件&amp;nbsp;------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com&amp;gt;;
发送时间:&amp;nbsp;2020年7月23日(星期四) 晚上10:50
收件人:&amp;nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&amp;gt;;
抄送:&amp;nbsp;"裴龙武"<peilongwu@qq.com&amp;gt;;"Author"<author@noreply.github.com&amp;gt;;
主题:&amp;nbsp;Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663314815
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上10:42
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
We can not include and use jsch officially in DolphinScheduler because of the licenses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663318296
It has a lot of cases to use many remote serves to execute some shell commands. So I think that we must to design a good method to support this feature.
I want to add a new table to manage the remote servers, but many committers feel that this change is too big. They think we can manage remote servers like data sources. So I develop this feature like this.
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上11:09
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
I switch to your branch and check the feature.
Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]
If you have any question or suggestion, welcome to put forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-671666332
> @peilongwu , supporting ssh task will be an important feature, and could you add password free to ssh task? by the way, please solve the conflicting files, thx
>
> > Hi,
> > When I set the password free login, and I do not set the password in the remote server settings, the following error will appear. Do we have to set the password when we want to login in the remote server? In a lot of scene, we already set the password free login. Can you add the password free login to the sshtask?
> > 
> > 
> > 
OK, I will perfect this feature in the next time. I was changing job recently. Now I work in a new company and I have times to finish this feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3283: Merge support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-662856262
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango removed a comment on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663046984
Hi,
We can not include and use `jsch` officially in DolphinScheduler because of the licenses.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu removed a comment on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu removed a comment on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-662860081
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 下午3:20
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663316417
I do not have a good idea to add many remote servers. If we can not add these remote servers to data source, we must develop a new feature to manage remote server.
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上11:09
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
I switch to your branch and check the feature.
Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]
If you have any question or suggestion, welcome to put forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663348278
Hi,
When I set the password free login, and I do not set the password in the remote server settings, the following error will appear. Do we have to set the password when we want to login in the remote server? In a lot of scene, we already set the password free login. Can you add the password free login to the sshtask?



----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663348278
When I set the password free login, and I do not set the password in the remote server settings, the following error will appear. Do we have to set the password when we want to login in the remote server? In a lot of scene, we already set the password free login. Can you add the password free login to the sshtask?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663313768
I add this test in root pom before.
I forgot to add this test when I solved the conflicts in this time.
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上7:55
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
@yangyichao-mango commented on this pull request.
In dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceService2Test.java:
> +import org.apache.dolphinscheduler.common.enums.UserType; +import org.apache.dolphinscheduler.dao.entity.User; +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.test.context.junit4.SpringRunner; + +import java.util.Map; + +@RunWith(SpringRunner.class) +@SpringBootTest(classes = ApiApplicationServer.class) +public class DataSourceService2Test {
Hi,
Why introduce this test case without adding this test to root pom?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-666464131
@peilongwu , supporting ssh task will be an important feature, and could you add password free to ssh task? by the way, please solve the conflicting files, thx
> Hi,
> When I set the password free login, and I do not set the password in the remote server settings, the following error will appear. Do we have to set the password when we want to login in the remote server? In a lot of scene, we already set the password free login. Can you add the password free login to the sshtask?
>
> 
> 
> 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663046984
Hi,
We can not include and use `jsch` officially in DolphinScheduler because of the licenses.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#discussion_r459394134
##########
File path: dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceService2Test.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.api.service;
+
+import org.apache.dolphinscheduler.api.ApiApplicationServer;
+import org.apache.dolphinscheduler.api.enums.Status;
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.enums.DbType;
+import org.apache.dolphinscheduler.common.enums.UserType;
+import org.apache.dolphinscheduler.dao.entity.User;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.context.junit4.SpringRunner;
+
+import java.util.Map;
+
+@RunWith(SpringRunner.class)
+@SpringBootTest(classes = ApiApplicationServer.class)
+public class DataSourceService2Test {
Review comment:
Hi,
Why introduce this test case without adding this test to root pom?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663316151
Hi,
I have checked the license of `jsch`, it is suitable for DolphinScheduler~
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月24日(星期五) 上午10:02
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "Yichao Yang"<1048262223@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------&nbsp;原始邮件&nbsp;------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com&gt;;
发送时间:&nbsp;2020年7月23日(星期四) 晚上10:50
收件人:&nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&gt;;
抄送:&nbsp;"裴龙武"<peilongwu@qq.com&gt;;"Author"<author@noreply.github.com&gt;;
主题:&nbsp;Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-676107813

there are some conflict files need to be sovled, please solve it locally, then I will merge into dev, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663315669
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上10:50
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663061973
Hi,
I switch to your branch and check the feature.
1. Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]
If you have any question or suggestion, welcome to put forward.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango removed a comment on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663051581
Hi,
Please make sure the 0.1.42 version license of `jsch` to avoid the license problem.



----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-662860081
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 下午3:20
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663051581
Hi,
Please make sure the 0.1.42 version license of `jsch` to avoid the license problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: Merge support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-662856955
OK, Got it
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 下午3:20
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-663051581
Hi,
Please make sure the 0.1.42 version license of `jsch` to avoid the license problem.



----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] peilongwu commented on pull request #3283: [Feature-2585][server] Support ssh command
Posted by GitBox <gi...@apache.org>.
peilongwu commented on pull request #3283:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3283#issuecomment-662860606
I already modify the pr title and comment.
------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 下午3:20
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org