You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Daniel Feist (JIRA)" <ji...@apache.org> on 2018/01/23 14:26:00 UTC

[jira] [Created] (LOG4J2-2212) Unnecessary contention in CopyOnWriteSortedArrayThreadContextMap

Daniel Feist created LOG4J2-2212:
------------------------------------

             Summary: Unnecessary contention in CopyOnWriteSortedArrayThreadContextMap
                 Key: LOG4J2-2212
                 URL: https://issues.apache.org/jira/browse/LOG4J2-2212
             Project: Log4j 2
          Issue Type: Improvement
    Affects Versions: 2.10.0
            Reporter: Daniel Feist
         Attachments: Screen Shot 2018-01-23 at 14.23.33.png

The following method retrieves the value of a system property for each and every map that is created.  While maps are cached/reused where possible via thread local this method is still used a lot in runtime.

{{protected StringMap createStringMap() {}}
{{return new SortedArrayStringMap(PropertiesUtil.getProperties().getIntegerProperty(}}
{{PROPERTY_NAME_INITIAL_CAPACITY, DEFAULT_INITIAL_CAPACITY));}}
{{}}}

Under concurrency, this introduces unnecessary contention due to java.util.Properties monitor in HashTable.contains when retrieving system, property.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)