You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/21 01:34:25 UTC
[GitHub] [activemq-artemis] zekeoptimo opened a new pull request #3143: Fix libaio1 docker dependency and rename Dockerfile-ubuntu to Dockerfile-debian
zekeoptimo opened a new pull request #3143:
URL: https://github.com/apache/activemq-artemis/pull/3143
The current Dockerfile based on openjdk:8 does not build due to an unavailable version of libaio1 specified. In addition, the Dockerfile states it is Ubuntu, when in fact openjdk:8 is now Debian.
I removed the hardcoded 0.3.110-3 libaio1 version, renamed the Dockerfile and updated the scripts and readme.md to indicate what changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] zekeoptimo commented on pull request #3143: Fix libaio1 docker dependency and rename Dockerfile-ubuntu to Dockerfile-debian
Posted by GitBox <gi...@apache.org>.
zekeoptimo commented on pull request #3143:
URL: https://github.com/apache/activemq-artemis/pull/3143#issuecomment-632230019
Thank you! I have created a Jira ticket, squashes the commits and created a new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] zekeoptimo closed pull request #3143: Fix libaio1 docker dependency and rename Dockerfile-ubuntu to Dockerfile-debian
Posted by GitBox <gi...@apache.org>.
zekeoptimo closed pull request #3143:
URL: https://github.com/apache/activemq-artemis/pull/3143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3143: Fix libaio1 docker dependency and rename Dockerfile-ubuntu to Dockerfile-debian
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3143:
URL: https://github.com/apache/activemq-artemis/pull/3143#issuecomment-632068708
awesome work...
only thing. it would be nice if you could create a JIRA.. and squash all these commits into one explaining all the changes... associated with the JIRA
```
ARTEMIS-XXX Docker Improvements
explain your changes here...
```
However, let me know if you can't do it.. and I will do it myself while merging your changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3143: Fix libaio1 docker dependency and rename Dockerfile-ubuntu to Dockerfile-debian
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3143:
URL: https://github.com/apache/activemq-artemis/pull/3143#issuecomment-632298114
@zekeoptimo you didn't need to create a new PR.. push -f would have done it..
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] zekeoptimo commented on pull request #3143: Fix libaio1 docker dependency and rename Dockerfile-ubuntu to Dockerfile-debian
Posted by GitBox <gi...@apache.org>.
zekeoptimo commented on pull request #3143:
URL: https://github.com/apache/activemq-artemis/pull/3143#issuecomment-632365765
@clebertsuconic thanks! Yeah, sorry about that, I wasn't familiar with squashing the commits and such - thanks for the tip, that makes sense.
Question: for the Jira ticket I created, do I close that myself ?
Lastly, I discovered another bug in the Dockerfiles. The ANONYMOUS_LOGIN environment var is never used and the result is that anonymous access is always enabled. I'm going to file another ticket for that and get another PR going once I've tested everything - I also have another simple change that will give more control over how the cluster is created that I'd like to add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org