You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Aster Anto (JIRA)" <ji...@apache.org> on 2012/04/28 15:21:48 UTC
[jira] [Created] (CXF-4273) WebClient.create(proxy) - does not
exist
Aster Anto created CXF-4273:
-------------------------------
Summary: WebClient.create(proxy) - does not exist
Key: CXF-4273
URL: https://issues.apache.org/jira/browse/CXF-4273
Project: CXF
Issue Type: Bug
Components: Documentation
Affects Versions: 2.6
Reporter: Aster Anto
Priority: Minor
Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
Method matching the following does not exist.
{noformat}WebClient client = WebClient.create(proxy);{noformat}
However, I got a WebClient from proxy by,
{noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
Client client = WebClient.client(proxy);
WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4273) WebClient.create(proxy) - does not
exist
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264739#comment-13264739 ]
Sergey Beryozkin commented on CXF-4273:
---------------------------------------
You are right, can you verify the latest update ?
I wonder if WebClient.fromClient(Client) should be updated to WebClient.fromClient(Object) which would internally delegate to WebClient.client(object), to get the proxy to WebClient conversion simpler...
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
> Key: CXF-4273
> URL: https://issues.apache.org/jira/browse/CXF-4273
> Project: CXF
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 2.6
> Reporter: Aster Anto
> Assignee: Sergey Beryozkin
> Priority: Minor
> Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CXF-4273) WebClient.create(proxy) - does not
exist
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Beryozkin resolved CXF-4273.
-----------------------------------
Resolution: Fixed
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
> Key: CXF-4273
> URL: https://issues.apache.org/jira/browse/CXF-4273
> Project: CXF
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 2.6
> Reporter: Aster Anto
> Assignee: Sergey Beryozkin
> Priority: Minor
> Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4273) WebClient.create(proxy) - does not
exist
Posted by "Aster Anto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264870#comment-13264870 ]
Aster Anto commented on CXF-4273:
---------------------------------
Well, site seems to be okay now. I couldn't find any delegation in "WebClient.fromClient(Client)" method as you mentioned. Yes, it is been taken to the next method -"WebClient fromClient(Client client, boolean inheritHeaders)" but then again a new "WebClient" is being created there based on the existing client.
To make proxy to WebClient conversion simpler, May be we can try
{noformat}WebClient webClient = WebClient.fromClient((Client) proxy);{noformat}
The only advantage "WebClient.client(proxy)" method provides is the instanceof expression, other than that, "WebClient.client(proxy)" method is just doing the casting.
Still I feel, its better to keep it the way it is now. Simple and less confusion for an average reader.
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
> Key: CXF-4273
> URL: https://issues.apache.org/jira/browse/CXF-4273
> Project: CXF
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 2.6
> Reporter: Aster Anto
> Assignee: Sergey Beryozkin
> Priority: Minor
> Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4273) WebClient.create(proxy) - does not
exist
Posted by "Aster Anto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264588#comment-13264588 ]
Aster Anto commented on CXF-4273:
---------------------------------
{noformat}WebClient client = WebClient.client(proxy);{noformat}
I fear that is not correct. What "WebClient.client(proxy)" returns is a "Client" not a "WebClient". We cannot cast "Client" to "WebClient" as well.
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
> Key: CXF-4273
> URL: https://issues.apache.org/jira/browse/CXF-4273
> Project: CXF
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 2.6
> Reporter: Aster Anto
> Assignee: Sergey Beryozkin
> Priority: Minor
> Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4273) WebClient.create(proxy) - does not
exist
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265016#comment-13265016 ]
Sergey Beryozkin commented on CXF-4273:
---------------------------------------
I was referring to the possible improvement, however, I guess it should be left as is at the moment, given that the proxy to/from http client conversions are not the typical operations, having to convert a proxy to the typed Client explicitly and then passing a Client ref to the typed fromClient method seems OK to me...
Btw, I'm resolving this specific documentation issue as fixed
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
> Key: CXF-4273
> URL: https://issues.apache.org/jira/browse/CXF-4273
> Project: CXF
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 2.6
> Reporter: Aster Anto
> Assignee: Sergey Beryozkin
> Priority: Minor
> Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CXF-4273) WebClient.create(proxy) - does not
exist
Posted by "Aster Anto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aster Anto reopened CXF-4273:
-----------------------------
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
> Key: CXF-4273
> URL: https://issues.apache.org/jira/browse/CXF-4273
> Project: CXF
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 2.6
> Reporter: Aster Anto
> Assignee: Sergey Beryozkin
> Priority: Minor
> Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CXF-4273) WebClient.create(proxy) - does not
exist
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Beryozkin resolved CXF-4273.
-----------------------------------
Resolution: Fixed
Assignee: Sergey Beryozkin
Please see
https://cwiki.apache.org/confluence/display/CXF20DOC/JAX-RS+Client+API
> WebClient.create(proxy) - does not exist
> ----------------------------------------
>
> Key: CXF-4273
> URL: https://issues.apache.org/jira/browse/CXF-4273
> Project: CXF
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 2.6
> Reporter: Aster Anto
> Assignee: Sergey Beryozkin
> Priority: Minor
> Labels: documentation
>
> Referring to http://cxf.apache.org/docs/jax-rs-client-api.html
> Method matching the following does not exist.
> {noformat}WebClient client = WebClient.create(proxy);{noformat}
> However, I got a WebClient from proxy by,
> {noformat}BookStore proxy = JAXRSClientFactory.create("http://books", BookStore.class);
> Client client = WebClient.client(proxy);
> WebClient webClient = WebClient.fromClient(client);{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira