You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/13 16:09:34 UTC

[GitHub] [pulsar] nodece opened a new issue, #16582: Test: mockito broken

nodece opened a new issue, #16582:
URL: https://github.com/apache/pulsar/issues/16582

   In our tests, I found this log that looks like the mockito broken:
   ```
    Error:  Tests run: 44, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 64.84 s <<< FAILURE! - in org.apache.pulsar.broker.service.persistent.PersistentTopicStreamingDispatcherTest
     Error:  setup(org.apache.pulsar.broker.service.persistent.PersistentTopicStreamingDispatcherTest)  Time elapsed: 0.22 s  <<< FAILURE!
     org.mockito.exceptions.base.MockitoException: Unable to create mock instance of type 'ServerCnx'
     	at org.apache.pulsar.broker.BrokerTestUtil.spyWithClassAndConstructorArgs(BrokerTestUtil.java:43)
     	at org.apache.pulsar.broker.service.PersistentTopicTest.setup(PersistentTopicTest.java:226)
     	at org.apache.pulsar.broker.service.persistent.PersistentTopicStreamingDispatcherTest.setup(PersistentTopicStreamingDispatcherTest.java:34)
     	at jdk.internal.reflect.GeneratedMethodAccessor599.invoke(Unknown Source)
     	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
     	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
     	at org.testng.internal.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:61)
     	at org.testng.internal.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:366)
     	at org.testng.internal.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:320)
     	at org.testng.internal.TestInvoker.runConfigMethods(TestInvoker.java:701)
     	at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:527)
     	at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
     	at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
     	at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
     	at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
     	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
     	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
     	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
     	at org.testng.TestRunner.privateRun(TestRunner.java:764)
     	at org.testng.TestRunner.run(TestRunner.java:585)
     	at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
     	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
     	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
     	at org.testng.SuiteRunner.run(SuiteRunner.java:286)
     	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
     	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
     	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
     	at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
     	at org.testng.TestNG.runSuites(TestNG.java:1069)
     	at org.testng.TestNG.run(TestNG.java:1037)
     	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:135)
     	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:112)
     	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeLazy(TestNGDirectoryTestSuite.java:123)
     	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:90)
     	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:146)
     	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
     	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
     	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
     	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
     Caused by: org.mockito.creation.instance.InstantiationException: 
     Unable to create instance of 'ServerCnx'.
     Please ensure the target class has a constructor that matches these argument types: [org.apache.pulsar.broker.PulsarService] and executes cleanly.
     	... 40 more
     Caused by: java.lang.reflect.InvocationTargetException
     	at org.mockito.internal.util.reflection.InstrumentationMemberAccessor.newInstance(InstrumentationMemberAccessor.java:198)
     	at org.mockito.internal.util.reflection.InstrumentationMemberAccessor.newInstance(InstrumentationMemberAccessor.java:161)
     	at org.mockito.internal.util.reflection.ModuleMemberAccessor.newInstance(ModuleMemberAccessor.java:42)
     	at org.mockito.internal.creation.instance.ConstructorInstantiator.invokeConstructor(ConstructorInstantiator.java:70)
     	at org.mockito.internal.creation.instance.ConstructorInstantiator.withParams(ConstructorInstantiator.java:53)
     	at org.mockito.internal.creation.instance.ConstructorInstantiator.newInstance(ConstructorInstantiator.java:39)
     	at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.doCreateMock(InlineDelegateByteBuddyMockMaker.java:360)
     	at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.createMock(InlineDelegateByteBuddyMockMaker.java:330)
     	at org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker.createMock(InlineByteBuddyMockMaker.java:58)
     	at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:53)
     	at org.mockito.internal.MockitoCore.mock(MockitoCore.java:84)
     	at org.mockito.Mockito.mock(Mockito.java:1964)
     	... 40 more
     Caused by: java.lang.ClassCastException: class org.apache.pulsar.broker.service.BrokerService cannot be cast to class org.apache.pulsar.broker.resources.PulsarResources (org.apache.pulsar.broker.service.BrokerService and org.apache.pulsar.broker.resources.PulsarResources are in unnamed module of loader 'app')
     	at org.apache.pulsar.broker.PulsarService.getPulsarResources(PulsarService.java:265)
     	at org.apache.pulsar.broker.service.TopicListService.<init>(TopicListService.java:103)
     	at org.apache.pulsar.broker.service.ServerCnx.<init>(ServerCnx.java:279)
     	at org.apache.pulsar.broker.service.ServerCnx.<init>(ServerCnx.java:239)
     	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
     	at org.mockito.internal.util.reflection.InstrumentationMemberAccessor$Dispatcher$ByteBuddy$kV10z9EX.invokeWithArguments(Unknown Source)
     	at org.mockito.internal.util.reflection.InstrumentationMemberAccessor.lambda$newInstance$0(InstrumentationMemberAccessor.java:191)
     	at org.mockito.internal.util.reflection.InstrumentationMemberAccessor.newInstance(InstrumentationMemberAccessor.java:188)
     	... 51 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on issue #16582: Test: mockito broken

Posted by GitBox <gi...@apache.org>.
nodece commented on issue #16582:
URL: https://github.com/apache/pulsar/issues/16582#issuecomment-1196539256

   @nicoloboschi We encountered this problem again, I think this is related to #15513.
   
   /cc @codelipenghui 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on issue #16582: Test: mockito broken

Posted by GitBox <gi...@apache.org>.
nodece commented on issue #16582:
URL: https://github.com/apache/pulsar/issues/16582#issuecomment-1197560233

   This issue should be able to fix by #16821.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on issue #16582: Test: mockito broken

Posted by GitBox <gi...@apache.org>.
nodece commented on issue #16582:
URL: https://github.com/apache/pulsar/issues/16582#issuecomment-1183916773

   @nicoloboschi Thanks for your fix, I need some tim to test this, if there no problem, I'll close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nicoloboschi commented on issue #16582: Test: mockito broken

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on issue #16582:
URL: https://github.com/apache/pulsar/issues/16582#issuecomment-1183453647

   @nodece have you seen it in the very latest master branch? 
   https://github.com/apache/pulsar/pull/15638 should have fixed this kind of issues 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] RobertIndie commented on issue #16582: Test: mockito broken

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on issue #16582:
URL: https://github.com/apache/pulsar/issues/16582#issuecomment-1196424622

   This issue still exist: https://github.com/apache/pulsar/runs/7534476083?check_suite_focus=true#step:10:711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece closed issue #16582: Test: mockito broken

Posted by GitBox <gi...@apache.org>.
nodece closed issue #16582: Test: mockito broken
URL: https://github.com/apache/pulsar/issues/16582


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org