You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "matrei (via GitHub)" <gi...@apache.org> on 2026/04/24 10:09:55 UTC
[PR] build: bootstrap Gradle plugin repositories [grails-core]
matrei opened a new pull request, #15597:
URL: https://github.com/apache/grails-core/pull/15597
Closes gh-15596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bootstrap Gradle plugin repositories [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15597:
URL: https://github.com/apache/grails-core/pull/15597#issuecomment-4319840824
I think we should merge to help @jamesfredley get the micronaut change merged quicker. Then we can revisit on the repo settings change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bootstrap Gradle plugin repositories [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15597:
URL: https://github.com/apache/grails-core/pull/15597#issuecomment-4312679291
## ✅ All tests passed ✅
🏷️ Commit: 0196bd2dd07cea4d4efe9e6eeba522ddba7ee87b
▶️ Tests: 26404 executed
⚪️ Checks: 31/31 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bootstrap Gradle plugin repositories [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #15597:
URL: https://github.com/apache/grails-core/pull/15597#discussion_r3139001052
##########
gradle/plugin-repositories.gradle:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+ext.configurePluginRepositories = { RepositoryHandler repositories ->
Review Comment:
We have a settings repo plugin. I'm assuming we can't take a similar solution for the plugin repos? If not, can we at least move this configuration adjacent to that plugin (build-logic) so they're in the same location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bootstrap Gradle plugin repositories [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15597:
URL: https://github.com/apache/grails-core/pull/15597#issuecomment-4320044361
@matrei would you be ok to relocate the config with the build-logic? James & I wanted to get this merged so we can get the micronaut changes merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bootstrap Gradle plugin repositories [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #15597:
URL: https://github.com/apache/grails-core/pull/15597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bootstrap Gradle plugin repositories [grails-core]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15597:
URL: https://github.com/apache/grails-core/pull/15597#issuecomment-4314684773
<!-- Bito Reply -->
Yes, we can move the plugin-repositories.gradle file into the build-logic directory to keep the configuration adjacent to the build-logic plugin. This would require updating the 'apply from' paths in both settings.gradle files to reference the new location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org