You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Andreas Pieber (JIRA)" <ji...@apache.org> on 2011/02/19 20:45:38 UTC

[jira] Created: (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Svnignores for support/groovy does not exclude eclipse files
------------------------------------------------------------

                 Key: SHIRO-272
                 URL: https://issues.apache.org/jira/browse/SHIRO-272
             Project: Shiro
          Issue Type: Bug
    Affects Versions: 1.1.0
            Reporter: Andreas Pieber
            Priority: Trivial
             Fix For: 1.2.0
         Attachments: svnignores-support-groovy.patch



-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Resolved: (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Posted by Les Hazlewood <lh...@apache.org>.
I think removing it is probably better for now.  If people want
Groovy-specific functionality, we can easily re-create the module if
anyone contributes anything.

That's just my opinion - I tend to like to clean out anything unused
rather than leave it there...

Les

On Sat, Feb 19, 2011 at 5:31 PM, Andreas Pieber <an...@gmail.com> wrote:
> Thank you very much for the explanation Les,
>
> I agree with you that there may be some need for a groovy support
> component, but till there is some implementation available we may...
>
> 1) ... remove the module (since it confuses beginners (like me :)) (or)
> 2) ... add a readme into support/groovy with the content of your answer
>
> WDYT?
>
> Kind regards,
> Andreas
>
> On Sun, Feb 20, 2011 at 2:24 AM, Les Hazlewood <lh...@apache.org> wrote:
>> That's because the groovy module was an idea at one time that didn't
>> flesh out into actual code.  There is no groovy-specific code at the
>> moment since Shiro can be used in Groovy environments transparently.
>> We should probably remove it.
>>
>> If there were to be something in the Groovy module, I would expect it
>> would probably have something like dynamic methods or other similar
>> things.  We just don't have any of those at the moment since most
>> Groovy/Grails users have been happy with the existing Java API.
>> Suggestions are welcome of course!
>>
>> Cheers,
>>
>> --
>> Les Hazlewood
>> Founder, Katasoft, Inc.
>> Application Security Products & Professional Apache Shiro Support and Training:
>> http://www.katasoft.com
>>
>> On Sat, Feb 19, 2011 at 5:04 PM, Andreas Pieber <an...@gmail.com> wrote:
>>> Mhm, I'm sure that I've provided the patch against the latest SVN
>>> version, but TBH I'm a little bit confused since support/groovy is
>>> empty except for a pom.xml and an empty source folder?
>>>
>>> kind regards,
>>> Andreas
>>>
>>> On Sat, Feb 19, 2011 at 10:50 PM, Kalle Korhonen (JIRA) <ji...@apache.org> wrote:
>>>>
>>>>     [ https://issues.apache.org/jira/browse/SHIRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>>
>>>> Kalle Korhonen resolved SHIRO-272.
>>>> ----------------------------------
>>>>
>>>>    Resolution: Fixed
>>>>
>>>> Thanks. Patch was created against an older revision, but added the Eclipse files to ignore
>>>>
>>>>> Svnignores for support/groovy does not exclude eclipse files
>>>>> ------------------------------------------------------------
>>>>>
>>>>>                 Key: SHIRO-272
>>>>>                 URL: https://issues.apache.org/jira/browse/SHIRO-272
>>>>>             Project: Shiro
>>>>>          Issue Type: Bug
>>>>>    Affects Versions: 1.1.0
>>>>>            Reporter: Andreas Pieber
>>>>>            Assignee: Kalle Korhonen
>>>>>            Priority: Trivial
>>>>>             Fix For: 1.2.0
>>>>>
>>>>>         Attachments: svnignores-support-groovy.patch
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] Resolved: (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Posted by Andreas Pieber <an...@gmail.com>.
Thank you very much for the explanation Les,

I agree with you that there may be some need for a groovy support
component, but till there is some implementation available we may...

1) ... remove the module (since it confuses beginners (like me :)) (or)
2) ... add a readme into support/groovy with the content of your answer

WDYT?

Kind regards,
Andreas

On Sun, Feb 20, 2011 at 2:24 AM, Les Hazlewood <lh...@apache.org> wrote:
> That's because the groovy module was an idea at one time that didn't
> flesh out into actual code.  There is no groovy-specific code at the
> moment since Shiro can be used in Groovy environments transparently.
> We should probably remove it.
>
> If there were to be something in the Groovy module, I would expect it
> would probably have something like dynamic methods or other similar
> things.  We just don't have any of those at the moment since most
> Groovy/Grails users have been happy with the existing Java API.
> Suggestions are welcome of course!
>
> Cheers,
>
> --
> Les Hazlewood
> Founder, Katasoft, Inc.
> Application Security Products & Professional Apache Shiro Support and Training:
> http://www.katasoft.com
>
> On Sat, Feb 19, 2011 at 5:04 PM, Andreas Pieber <an...@gmail.com> wrote:
>> Mhm, I'm sure that I've provided the patch against the latest SVN
>> version, but TBH I'm a little bit confused since support/groovy is
>> empty except for a pom.xml and an empty source folder?
>>
>> kind regards,
>> Andreas
>>
>> On Sat, Feb 19, 2011 at 10:50 PM, Kalle Korhonen (JIRA) <ji...@apache.org> wrote:
>>>
>>>     [ https://issues.apache.org/jira/browse/SHIRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>
>>> Kalle Korhonen resolved SHIRO-272.
>>> ----------------------------------
>>>
>>>    Resolution: Fixed
>>>
>>> Thanks. Patch was created against an older revision, but added the Eclipse files to ignore
>>>
>>>> Svnignores for support/groovy does not exclude eclipse files
>>>> ------------------------------------------------------------
>>>>
>>>>                 Key: SHIRO-272
>>>>                 URL: https://issues.apache.org/jira/browse/SHIRO-272
>>>>             Project: Shiro
>>>>          Issue Type: Bug
>>>>    Affects Versions: 1.1.0
>>>>            Reporter: Andreas Pieber
>>>>            Assignee: Kalle Korhonen
>>>>            Priority: Trivial
>>>>             Fix For: 1.2.0
>>>>
>>>>         Attachments: svnignores-support-groovy.patch
>>>>
>>>>
>>>
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Re: [jira] Resolved: (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Posted by Les Hazlewood <lh...@apache.org>.
That's because the groovy module was an idea at one time that didn't
flesh out into actual code.  There is no groovy-specific code at the
moment since Shiro can be used in Groovy environments transparently.
We should probably remove it.

If there were to be something in the Groovy module, I would expect it
would probably have something like dynamic methods or other similar
things.  We just don't have any of those at the moment since most
Groovy/Grails users have been happy with the existing Java API.
Suggestions are welcome of course!

Cheers,

-- 
Les Hazlewood
Founder, Katasoft, Inc.
Application Security Products & Professional Apache Shiro Support and Training:
http://www.katasoft.com

On Sat, Feb 19, 2011 at 5:04 PM, Andreas Pieber <an...@gmail.com> wrote:
> Mhm, I'm sure that I've provided the patch against the latest SVN
> version, but TBH I'm a little bit confused since support/groovy is
> empty except for a pom.xml and an empty source folder?
>
> kind regards,
> Andreas
>
> On Sat, Feb 19, 2011 at 10:50 PM, Kalle Korhonen (JIRA) <ji...@apache.org> wrote:
>>
>>     [ https://issues.apache.org/jira/browse/SHIRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Kalle Korhonen resolved SHIRO-272.
>> ----------------------------------
>>
>>    Resolution: Fixed
>>
>> Thanks. Patch was created against an older revision, but added the Eclipse files to ignore
>>
>>> Svnignores for support/groovy does not exclude eclipse files
>>> ------------------------------------------------------------
>>>
>>>                 Key: SHIRO-272
>>>                 URL: https://issues.apache.org/jira/browse/SHIRO-272
>>>             Project: Shiro
>>>          Issue Type: Bug
>>>    Affects Versions: 1.1.0
>>>            Reporter: Andreas Pieber
>>>            Assignee: Kalle Korhonen
>>>            Priority: Trivial
>>>             Fix For: 1.2.0
>>>
>>>         Attachments: svnignores-support-groovy.patch
>>>
>>>
>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] Resolved: (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Posted by Andreas Pieber <an...@gmail.com>.
Mhm, I'm sure that I've provided the patch against the latest SVN
version, but TBH I'm a little bit confused since support/groovy is
empty except for a pom.xml and an empty source folder?

kind regards,
Andreas

On Sat, Feb 19, 2011 at 10:50 PM, Kalle Korhonen (JIRA) <ji...@apache.org> wrote:
>
>     [ https://issues.apache.org/jira/browse/SHIRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Kalle Korhonen resolved SHIRO-272.
> ----------------------------------
>
>    Resolution: Fixed
>
> Thanks. Patch was created against an older revision, but added the Eclipse files to ignore
>
>> Svnignores for support/groovy does not exclude eclipse files
>> ------------------------------------------------------------
>>
>>                 Key: SHIRO-272
>>                 URL: https://issues.apache.org/jira/browse/SHIRO-272
>>             Project: Shiro
>>          Issue Type: Bug
>>    Affects Versions: 1.1.0
>>            Reporter: Andreas Pieber
>>            Assignee: Kalle Korhonen
>>            Priority: Trivial
>>             Fix For: 1.2.0
>>
>>         Attachments: svnignores-support-groovy.patch
>>
>>
>
>
> --
> This message is automatically generated by JIRA.
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>

[jira] [Closed] (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Posted by "Les Hazlewood (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Les Hazlewood closed SHIRO-272.
-------------------------------


Closing with the 1.2.0 release.
                
> Svnignores for support/groovy does not exclude eclipse files
> ------------------------------------------------------------
>
>                 Key: SHIRO-272
>                 URL: https://issues.apache.org/jira/browse/SHIRO-272
>             Project: Shiro
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Andreas Pieber
>            Assignee: Kalle Korhonen
>            Priority: Trivial
>             Fix For: 1.2.0
>
>         Attachments: svnignores-support-groovy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kalle Korhonen resolved SHIRO-272.
----------------------------------

    Resolution: Fixed

Thanks. Patch was created against an older revision, but added the Eclipse files to ignore

> Svnignores for support/groovy does not exclude eclipse files
> ------------------------------------------------------------
>
>                 Key: SHIRO-272
>                 URL: https://issues.apache.org/jira/browse/SHIRO-272
>             Project: Shiro
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Andreas Pieber
>            Assignee: Kalle Korhonen
>            Priority: Trivial
>             Fix For: 1.2.0
>
>         Attachments: svnignores-support-groovy.patch
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (SHIRO-272) Svnignores for support/groovy does not exclude eclipse files

Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHIRO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kalle Korhonen reassigned SHIRO-272:
------------------------------------

    Assignee: Kalle Korhonen

> Svnignores for support/groovy does not exclude eclipse files
> ------------------------------------------------------------
>
>                 Key: SHIRO-272
>                 URL: https://issues.apache.org/jira/browse/SHIRO-272
>             Project: Shiro
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Andreas Pieber
>            Assignee: Kalle Korhonen
>            Priority: Trivial
>             Fix For: 1.2.0
>
>         Attachments: svnignores-support-groovy.patch
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira