You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/02 05:57:21 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1376: HDDS-3762. Intermittent failure in TestDeleteWithSlowFollower

adoroszlai opened a new pull request #1376:
URL: https://github.com/apache/hadoop-ozone/pull/1376


   ## What changes were proposed in this pull request?
   
   Intermittent failure in `testDeleteKeyWithSlowFollower` seems to be caused by:
   
   * `DeleteBlocksCommandHandler` increments `invocationCount` near the beginning of `handle()`, and only updates `deleteTransactionId` later
   * `TestDeleteWithSlowFollower` waits for `invocationCount >= 1`, then asserts `deleteTransactionId` also increased
   
   The test is fixed by changing the order in the handler: only increment `invocationCount` at the end, when `deleteTransactionId` is already updated.
   
   I think `invocationCount` should be updated together with `totalTime` to provide (slightly more) correct average run time (`getAverageRunTime`).
   
   https://issues.apache.org/jira/browse/HDDS-3762
   
   ## How was this patch tested?
   
   Passed 50x:
   https://github.com/adoroszlai/hadoop-ozone/runs/1059570465#step:5:4
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/runs/1059560880


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1376: HDDS-3762. Intermittent failure in TestDeleteWithSlowFollower

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1376:
URL: https://github.com/apache/hadoop-ozone/pull/1376#issuecomment-686431307


   Thanks @bshashikant for reviewing and committing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bshashikant commented on pull request #1376: HDDS-3762. Intermittent failure in TestDeleteWithSlowFollower

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #1376:
URL: https://github.com/apache/hadoop-ozone/pull/1376#issuecomment-686250909


   Thanks @adoroszlai for the contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bshashikant merged pull request #1376: HDDS-3762. Intermittent failure in TestDeleteWithSlowFollower

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #1376:
URL: https://github.com/apache/hadoop-ozone/pull/1376


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org