You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/02/29 08:54:27 UTC
Re: Review Request 42590: Removed reserved() API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/
-----------------------------------------------------------
(Updated 二月 29, 2016, 7:54 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Changes
-------
Rebase
Bugs: MESOS-4447
https://issues.apache.org/jira/browse/MESOS-4447
Repository: mesos
Description
-------
Removed reserved() API.
Diffs
-----
include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7
src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/42590/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 42590: Removed reserved() API.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review121213
-----------------------------------------------------------
Bad patch!
Reviews applied: [42590]
Failed command: ./support/apply-review.sh -n -r 42590
Error:
2016-02-29 08:34:54 URL:https://reviews.apache.org/r/42590/diff/raw/ [5284/5284] -> "42590.patch" [1]
error: patch failed: include/mesos/resources.hpp:235
error: include/mesos/resources.hpp: patch does not apply
error: patch failed: include/mesos/v1/resources.hpp:235
error: include/mesos/v1/resources.hpp: patch does not apply
error: patch failed: src/common/resources.cpp:808
error: src/common/resources.cpp: patch does not apply
error: patch failed: src/master/http.cpp:475
error: src/master/http.cpp: patch does not apply
error: patch failed: src/v1/resources.cpp:802
error: src/v1/resources.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/11729/console
- Mesos ReviewBot
On Feb. 29, 2016, 7:54 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 7:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed reserved() API.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa
> include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c
> src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a
> src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7
> src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/42590/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42590: Removed reserved() API.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review121220
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42590]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 29, 2016, 9:11 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 9:11 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed reserved() API.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f
> include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e
> src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2
> src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74
> src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11
> src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc
>
> Diff: https://reviews.apache.org/r/42590/diff/
>
>
> Testing
> -------
>
> make
> make check
> ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42590: Renamed reserved() to reservations().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review123266
-----------------------------------------------------------
I left a comment but I'll take care of that for you before committing.
include/mesos/resources.hpp (lines 224 - 229)
<https://reviews.apache.org/r/42590/#comment185471>
Would be great to update the documentation here to reflect the changes.
- Ben Mahler
On March 12, 2016, 2:47 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
>
> (Updated March 12, 2016, 2:47 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed reserved() to reservations().
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176
> include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e
> src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
> src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2
> src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
> src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
>
> Diff: https://reviews.apache.org/r/42590/diff/
>
>
> Testing
> -------
>
> make
> make check
> ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42590: Renamed reserved() to reservations().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review123265
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 12, 2016, 2:47 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
>
> (Updated March 12, 2016, 2:47 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed reserved() to reservations().
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176
> include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e
> src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
> src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2
> src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
> src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
>
> Diff: https://reviews.apache.org/r/42590/diff/
>
>
> Testing
> -------
>
> make
> make check
> ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42590: Renamed reserved() to reservations().
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review123267
-----------------------------------------------------------
include/mesos/resources.hpp (line 228)
<https://reviews.apache.org/r/42590/#comment185472>
I think we need to update document about the `Option<std::string> role`
- Klaus Ma
On March 12, 2016, 10:47 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
>
> (Updated March 12, 2016, 10:47 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed reserved() to reservations().
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176
> include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e
> src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
> src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2
> src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
> src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
>
> Diff: https://reviews.apache.org/r/42590/diff/
>
>
> Testing
> -------
>
> make
> make check
> ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42590: Renamed reserved() to reservations().
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review123270
-----------------------------------------------------------
Bad patch!
Reviews applied: [42590]
Failed command: ./support/apply-review.sh -n -r 42590
Error:
2016-03-12 04:33:44 URL:https://reviews.apache.org/r/42590/diff/raw/ [4988/4988] -> "42590.patch" [1]
error: patch failed: include/mesos/resources.hpp:222
error: include/mesos/resources.hpp: patch does not apply
error: patch failed: include/mesos/v1/resources.hpp:222
error: include/mesos/v1/resources.hpp: patch does not apply
error: patch failed: src/common/resources.cpp:859
error: src/common/resources.cpp: patch does not apply
error: patch failed: src/master/http.cpp:168
error: src/master/http.cpp: patch does not apply
error: patch failed: src/tests/resources_tests.cpp:1460
error: src/tests/resources_tests.cpp: patch does not apply
error: patch failed: src/v1/resources.cpp:862
error: src/v1/resources.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/11958/console
- Mesos ReviewBot
On March 12, 2016, 2:47 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
>
> (Updated March 12, 2016, 2:47 a.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4447
> https://issues.apache.org/jira/browse/MESOS-4447
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed reserved() to reservations().
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176
> include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e
> src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
> src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2
> src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
> src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
>
> Diff: https://reviews.apache.org/r/42590/diff/
>
>
> Testing
> -------
>
> make
> make check
> ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 42590: Renamed reserved() to reservations().
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/
-----------------------------------------------------------
(Updated 三月 12, 2016, 2:47 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Summary (updated)
-----------------
Renamed reserved() to reservations().
Bugs: MESOS-4447
https://issues.apache.org/jira/browse/MESOS-4447
Repository: mesos
Description (updated)
-------
Renamed reserved() to reservations().
Diffs (updated)
-----
include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176
include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e
src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2
src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
Diff: https://reviews.apache.org/r/42590/diff/
Testing
-------
make
make check
./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
Thanks,
Guangya Liu
Re: Review Request 42590: Removed reserved() API.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/
-----------------------------------------------------------
(Updated 三月 11, 2016, 9:08 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-4447
https://issues.apache.org/jira/browse/MESOS-4447
Repository: mesos
Description
-------
Removed reserved() API.
Diffs (updated)
-----
include/mesos/resources.hpp 388c4f383b77be490cb2debb64a734c6d6e4a176
include/mesos/v1/resources.hpp 64ad8bf08230aeaa173325364c91b765f091210e
src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd
src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
Diff: https://reviews.apache.org/r/42590/diff/
Testing
-------
make
make check
./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
Thanks,
Guangya Liu
Re: Review Request 42590: Removed reserved() API.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/
-----------------------------------------------------------
(Updated 二月 29, 2016, 9:11 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-4447
https://issues.apache.org/jira/browse/MESOS-4447
Repository: mesos
Description
-------
Removed reserved() API.
Diffs (updated)
-----
include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f
include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e
src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2
src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74
src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11
src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc
Diff: https://reviews.apache.org/r/42590/diff/
Testing (updated)
-------
make
make check
./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*"
Thanks,
Guangya Liu