You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/08/17 13:32:48 UTC
[GitHub] incubator-brooklyn pull request: Test + fix BrooklynAccessUtils
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/831
Test + fix BrooklynAccessUtils
- Previously there were no unit tests!
- Previously would not look up PortForwardManager unless machine
implemented SupportsPortForwarding (which broke BYON’s tcpPortMappings)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/BrooklynAccessUtils
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit ee1a20a04bacafba6633c3b7ec2e80635490310d
Author: Aled Sage <al...@gmail.com>
Date: 2015-08-17T11:32:38Z
Test + fix BrooklynAccessUtils
- Previously there were no unit tests!
- Previously would not look up PortForwardManager unless machine
implemented SupportsPortForwarding (which broke BYON’s tcpPortMappings)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Test + fix BrooklynAccessUtils
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/831#issuecomment-131812084
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Test + fix BrooklynAccessUtils
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Test + fix BrooklynAccessUtils
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/831#issuecomment-131968100
Build failed with `Build timed out (after 40 minutes). Marking the build as aborted.` Closing and re-opening PR to kick off asfbot again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Test + fix BrooklynAccessUtils
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/831#issuecomment-132172930
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Test + fix BrooklynAccessUtils
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/831
Test + fix BrooklynAccessUtils
- Previously there were no unit tests!
- Previously would not look up PortForwardManager unless machine
implemented SupportsPortForwarding (which broke BYON’s tcpPortMappings)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/BrooklynAccessUtils
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit ee1a20a04bacafba6633c3b7ec2e80635490310d
Author: Aled Sage <al...@gmail.com>
Date: 2015-08-17T11:32:38Z
Test + fix BrooklynAccessUtils
- Previously there were no unit tests!
- Previously would not look up PortForwardManager unless machine
implemented SupportsPortForwarding (which broke BYON’s tcpPortMappings)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Test + fix BrooklynAccessUtils
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---