You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2023/07/15 17:20:03 UTC
[GitHub] [hbase-operator-tools] NihalJain opened a new pull request, #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
NihalJain opened a new pull request, #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131
…region list into file(s) which can be passed as input(s) to assigns command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639759049
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 41s | master passed |
| +1 :green_heart: | compile | 0m 11s | master passed |
| +1 :green_heart: | checkstyle | 0m 7s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 12s | the patch passed |
| +1 :green_heart: | compile | 0m 10s | the patch passed |
| +1 :green_heart: | javac | 0m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 5s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 52s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 7m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/5/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/131 |
| Optional Tests | dupname asflicense markdownlint javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 1f17761ddf7f 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / efa1916 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/5/testReport/ |
| Max. process+thread count | 1262 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/5/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on a diff in pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "wchevreuil (via GitHub)" <gi...@apache.org>.
wchevreuil commented on code in PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#discussion_r1265055551
##########
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##########
@@ -586,7 +653,18 @@ private static void usageAddFsRegionsMissingInMeta(PrintWriter writer) {
writer.println(" Each file contains <NAMESPACE|NAMESPACE:TABLENAME>, one per line.");
writer.println(" For example:");
writer.println(" $ HBCK2 " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES +
- " -i fileName1 fileName2");
+ " -i fileName1 fileName2");
+ writer.println(" If -o or --outputFile is specified, the output file(s) can be passed as");
+ writer.println(" input to assigns command via -i or -inputFiles option.");
+ writer.println(" If -n or --numLines is specified, and say it is set to 100, this will");
Review Comment:
nit: mention this should be used together with the `-o` option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636853685
Hi @wchevreuil could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1682218560
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | master passed |
| +1 :green_heart: | compile | 0m 11s | master passed |
| +1 :green_heart: | checkstyle | 0m 7s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 11s | the patch passed |
| +1 :green_heart: | compile | 0m 10s | the patch passed |
| +1 :green_heart: | javac | 0m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 4s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 54s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 8m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/6/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/131 |
| Optional Tests | dupname asflicense markdownlint javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 2b17fabb0854 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / ca3b96f |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/6/testReport/ |
| Max. process+thread count | 1269 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/6/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1682195848
The 2nd commit 05795bfc3e338cc8d6a9acab66863868ea3f9d51 was a nit change affecting only docs. The 1st commit has been reviewed by @wchevreuil.
Will wait for others for another day for more reviews, else will go ahead and merge, if no concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639760655
> Also, will be creating another ticket as I see there are differences in the hbck2 doc and the command help output, hence we should sync them across all command. Did not piggy back those changes here to keep this PR clean.
Raised [HBASE-27980](https://issues.apache.org/jira/browse/HBASE-27980)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on a diff in pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#discussion_r1297144091
##########
hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java:
##########
@@ -586,7 +653,18 @@ private static void usageAddFsRegionsMissingInMeta(PrintWriter writer) {
writer.println(" Each file contains <NAMESPACE|NAMESPACE:TABLENAME>, one per line.");
writer.println(" For example:");
writer.println(" $ HBCK2 " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES +
- " -i fileName1 fileName2");
+ " -i fileName1 fileName2");
+ writer.println(" If -o or --outputFile is specified, the output file(s) can be passed as");
+ writer.println(" input to assigns command via -i or -inputFiles option.");
+ writer.println(" If -n or --numLines is specified, and say it is set to 100, this will");
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain merged pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1673468858
Gentle ping @wchevreuil, let me know if this revised PR looks good to you.
CC: @petersomogyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636841073
Also while testing, encountered HBASE-27961. Will work on batching for assignment as part of that JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639660094
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 52s | master passed |
| +1 :green_heart: | compile | 0m 10s | master passed |
| +1 :green_heart: | checkstyle | 0m 7s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 12s | the patch passed |
| +1 :green_heart: | compile | 0m 10s | the patch passed |
| +1 :green_heart: | javac | 0m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 5s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 51s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 7m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/4/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 948f36ec06a8 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / efa1916 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/4/testReport/ |
| Max. process+thread count | 1262 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/4/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636839483
[Following was done to test the code changes:
- Build the repo with HBase 2.5.x
- Print help to see it works as expected
- Create a table with 7070 regions and do full hbase meta repair by dropping meta table data from hdfs
- Tested the newly added functionality against a 2.5.x cluster and verified assigns is able to pickup the output
- Verified expected number of files are created as per input and data
Truncated test logs for reference:
```
$ export HBCK_JAR=hbase-hbck2-1.3.0-SNAPSHOT.jar
$ hbase hbck -j $HBCK_JAR
usage: HBCK2 [OPTIONS] COMMAND <ARGS>
Options:
-d,--debug run with debug output
-h,--help output this help message
-p,--hbase.zookeeper.property.clientPort <arg> port of hbase ensemble
-q,--hbase.zookeeper.quorum <arg> hbase ensemble
-s,--skip skip hbase version check
(PleaseHoldException)
-v,--version this hbck2 version
-z,--zookeeper.znode.parent <arg> parent znode of hbase
ensemble
Command:
addFsRegionsMissingInMeta [OPTIONS]
[<NAMESPACE|NAMESPACE:TABLENAME>...|-i <INPUTFILES>...]
Options:
-i,--inputFiles take one or more files of namespace or table names
-o,--outputFile name/prefix of the file(s) to dump region names
-n,--numLines number of lines to be written to each output file
To be used when regions missing from hbase:meta but directories
are present still in HDFS. Can happen if user has run _hbck1_
'OfflineMetaRepair' against an hbase-2.x cluster. Needs hbase:meta
to be online. For each table name passed as parameter, performs diff
between regions available in hbase:meta and region dirs on HDFS.
Then for dirs with no hbase:meta matches, it reads the 'regioninfo'
metadata file and re-creates given region in hbase:meta. Regions are
re-created in 'CLOSED' state in the hbase:meta table, but not in the
Masters' cache, and they are not assigned either. To get these
regions online, run the HBCK2 'assigns'command printed when this
command-run completes.
NOTE: If using hbase releases older than 2.3.0, a rolling restart of
HMasters is needed prior to executing the set of 'assigns' output.
An example adding missing regions for tables 'tbl_1' in the default
namespace, 'tbl_2' in namespace 'n1' and for all tables from
namespace 'n2':
$ HBCK2 addFsRegionsMissingInMeta default:tbl_1 n1:tbl_2 n2
Returns HBCK2 an 'assigns' command with all re-inserted regions.
SEE ALSO: reportMissingRegionsInMeta
SEE ALSO: fixMeta
If -i or --inputFiles is specified, pass one or more input file names.
Each file contains <NAMESPACE|NAMESPACE:TABLENAME>, one per line.
For example:
$ HBCK2 addFsRegionsMissingInMeta -i fileName1 fileName2
If -o or --outputFile is specified, the output file(s) can be passed as
input to assigns command via -i or -inputFiles option.
If -n or --numLines is specified, and say it is set to 100, this will
create files with prefix as value passed by -o or --outputFile option.
Each file will have 100 region names (max.), one per line.
For example:
$ HBCK2 addFsRegionsMissingInMeta -i fileName1 fileName2
-o outputFilePrefix -n 100
But if -n is not specified, but -o is specified, it will dump all
region names in a single file, one per line.
For example:
$ HBCK2 addFsRegionsMissingInMeta -i fileName1 fileName2
-o outputFileName
assigns [OPTIONS] [<ENCODED_REGIONNAME>...|-i <INPUT_FILE>...]
.
.
$ cat namesapce.txt
hbase:namespace
$ cat acl.txt
hbase:acl
hbase hbck -j $HBCK_JAR addFsRegionsMissingInMeta -i namesapce.txt acl.txt -o test/system_regions.txt
Dumping region names to file: /tmp/test/system_regions.txt
Regions re-added into Meta: 2
WARNING:
2 regions were added to META, but these are not yet on Masters cache.
You need to restart Masters, then run hbck2 'assigns' command below:
assigns 708ade6cca88d7a2b8d7e8b045b1c715 8343b51276a70f081f6574c1a6cb5296
$ cat test/system_regions.txt
708ade6cca88d7a2b8d7e8b045b1c715
8343b51276a70f081f6574c1a6cb5296
$ hbase hbck -j $HBCK_JAR assigns -i test/system_regions.txt
[4, 5]
$ hbase hbck -j $HBCK_JAR addFsRegionsMissingInMeta -o test/user_regions.txt -n 1000 default
Dumping region names to file: /tmp/test/user_regions.txt.0
Dumping region names to file: /tmp/test/user_regions.txt.1
Dumping region names to file: /tmp/test/user_regions.txt.2
Dumping region names to file: /tmp/test/user_regions.txt.3
Dumping region names to file: /tmp/test/user_regions.txt.4
Dumping region names to file: /tmp/test/user_regions.txt.5
Dumping region names to file: /tmp/test/user_regions.txt.6
Dumping region names to file: /tmp/test/user_regions.txt.7
Regions re-added into Meta: 7070
WARNING:
7070 regions were added to META, but these are not yet on Masters cache.
You need to restart Masters, then run hbck2 'assigns' command below:
assigns 000c83ba37b585bf2870af11d9b8acce 00117ed0e16e098d0aa9df14461756b0 001295576c21b98ec63b99149f54497e . . .
$ ls test/user_regions.txt.*
test/user_regions.txt.0 test/user_regions.txt.2 test/user_regions.txt.4 test/user_regions.txt.6
test/user_regions.txt.1 test/user_regions.txt.3 test/user_regions.txt.5 test/user_regions.txt.7
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.0
[8, 9, 10, . . . ]
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.1
[2008, 2009, 2010, . . . ]
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.2
[4008, 4009, 4010, . . . ]
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.3
[6008, 6009, 6010, . . . ]
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.4
[8008, 8009, 8010, . . . ]
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.5
[10008, 10009, 10010, . . . ]
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.6
[12008, 12009, 12010, . . . ]
$ hbase hbck -j $HBCK_JAR assigns -i test/user_regions.txt.7
[14008, 14009, 14010, . . . ]
$
```
Full test logs for reference:
[test_HBASE-27724.txt](https://github.com/apache/hbase-operator-tools/files/12062387/test_HBASE-27724.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636833913
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 43s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | master passed |
| +1 :green_heart: | compile | 0m 11s | master passed |
| +1 :green_heart: | checkstyle | 0m 7s | master passed |
| +1 :green_heart: | javadoc | 0m 7s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 12s | the patch passed |
| +1 :green_heart: | compile | 0m 10s | the patch passed |
| +1 :green_heart: | javac | 0m 10s | the patch passed |
| -1 :x: | checkstyle | 0m 5s | hbase-hbck2: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 50s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 8m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 6a4cea108cca 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / efa1916 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| checkstyle | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/1/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-hbck2.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/1/testReport/ |
| Max. process+thread count | 1271 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/1/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639714043
Hey just realized, need to sync hbck2 doc, please do not merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636880496
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 43s | master passed |
| +1 :green_heart: | compile | 0m 10s | master passed |
| +1 :green_heart: | checkstyle | 0m 8s | master passed |
| +1 :green_heart: | javadoc | 0m 8s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 11s | the patch passed |
| +1 :green_heart: | compile | 0m 11s | the patch passed |
| +1 :green_heart: | javac | 0m 11s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 5s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 55s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 7m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/3/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 6ccd4fb11225 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / efa1916 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/3/testReport/ |
| Max. process+thread count | 1260 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/3/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1636851352
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 44s | master passed |
| +1 :green_heart: | compile | 0m 10s | master passed |
| +1 :green_heart: | checkstyle | 0m 8s | master passed |
| +1 :green_heart: | javadoc | 0m 8s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 11s | the patch passed |
| +1 :green_heart: | compile | 0m 10s | the patch passed |
| +1 :green_heart: | javac | 0m 10s | the patch passed |
| -1 :x: | checkstyle | 0m 4s | hbase-hbck2: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 56s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | asflicense | 0m 6s | The patch does not generate ASF License warnings. |
| | | 7m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/131 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux c82e5e30de67 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / efa1916 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| checkstyle | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/2/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-hbck2.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/2/testReport/ |
| Max. process+thread count | 1260 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 U: hbase-hbck2 |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-131/2/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1639744953
Synced the doc. Good for review. @wchevreuil
Also, will be creating another ticket as I see there are differences in the hbck2 doc and the command help output, hence we should sync them across all command. Did not piggy back those changes here to keep this PR clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] NihalJain commented on pull request #131: HBASE-27724 addFsRegionsMissingInMeta command should support dumping …
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #131:
URL: https://github.com/apache/hbase-operator-tools/pull/131#issuecomment-1682188243
Rebased code to resolve conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org