You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/08 06:49:26 UTC

[GitHub] [arrow-rs] roee88 opened a new pull request #674: Make rand an optional dependency

roee88 opened a new pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674


   # Which issue does this PR close?
   
   Closes #671
   
   # Rationale for this change
    
   Support wasm32-unknown-unknown target in environments without JavaScript.
   
   # What changes are included in this PR?
   
   1. Change `rand` to be an optional dependency
   2. Add `rand` as a dev dependency
   3. Updated Building for WASM section in README
   4. Add wasm32-wasi test in CI
   
   # Are there any user-facing changes?
   
   Instructions for compiling to wasm32-unknown-unknown changed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684753864



##########
File path: arrow/Cargo.toml
##########
@@ -64,16 +61,18 @@ csv = ["csv_crate"]
 ipc = ["flatbuffers"]
 simd = ["packed_simd"]
 prettyprint = ["prettytable-rs"]
-js = ["getrandom/js"]
 # The test utils feature enables code used in benchmarks and tests but
-# not the core arrow code itself
-test_utils = ["rand/std", "rand/std_rng"]
+# not the core arrow code itself. Be aware that `rand` must be kept as 
+# an optional dependency for supporting compile to wasm32-unknown-unknown 
+# target without assuming an environment containing JavaScript.
+test_utils = ["rand"]

Review comment:
       👍 

##########
File path: arrow/README.md
##########
@@ -59,11 +59,13 @@ println!("{:?}", array.value(1));
 
 ## Building for WASM
 
-In order to compile Arrow for Web Assembly (the `wasm32-unknown-unknown` WASM target), you will likely need to turn off this crate's default features and use the `js` feature.
+Arrow can compile to WebAssembly using the `wasm32-unknown-unknown` and `wasm32-wasi` targets.
+
+In order to compile Arrow for `wasm32-unknown-unknown` you will need to exclude test dependencies (the `test_utils` feature). For example, use this snippet in your `Cargo.toml`:
 
 ```toml
 [dependencies]
-arrow = { version = "5.0", default-features = false, features = ["js"] }
+arrow = { version = "5.0", default-features = false, features = ["csv", "ipc", "simd"] }
 ```
 

Review comment:
       See also https://github.com/apache/arrow-rs/pull/656 from @PsiACE  -- I am not sure if the same applies to comfy-table




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] roee88 commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
roee88 commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684725663



##########
File path: .github/workflows/rust.yml
##########
@@ -327,12 +327,14 @@ jobs:
           rustup override set ${{ matrix.rust }}
           rustup component add rustfmt
           rustup target add wasm32-unknown-unknown
+          rustup target add wasm32-wasi
       - name: Build arrow crate
         run: |
           export CARGO_HOME="/github/home/.cargo"
           export CARGO_TARGET_DIR="/github/home/target"
           cd arrow
-          cargo build --features=js --target wasm32-unknown-unknown
+          cargo build --no-default-features --features=csv,ipc,simd --target wasm32-unknown-unknown
+          cargo build --no-default-features --features=csv,ipc,simd --target wasm32-wasi

Review comment:
       Specifically for `wasm32-wasi` there is no real need to exclude test dependencies so `cargo build --features=simd --target wasm32-wasi` or `cargo build --target wasm32-wasi` also work. However, I don't see a real reason to include it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] roee88 commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
roee88 commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684726091



##########
File path: arrow/README.md
##########
@@ -59,11 +59,13 @@ println!("{:?}", array.value(1));
 
 ## Building for WASM
 
-In order to compile Arrow for Web Assembly (the `wasm32-unknown-unknown` WASM target), you will likely need to turn off this crate's default features and use the `js` feature.
+Arrow can compile to WebAssembly using the `wasm32-unknown-unknown` and `wasm32-wasi` targets.
+
+In order to compile Arrow for `wasm32-unknown-unknown` you will need to exclude test dependencies (the `test_utils` feature). For example, use this snippet in your `Cargo.toml`:
 
 ```toml
 [dependencies]
-arrow = { version = "5.0", default-features = false, features = ["js"] }
+arrow = { version = "5.0", default-features = false, features = ["csv", "ipc", "simd"] }
 ```
 

Review comment:
       ### side note
   
   When compiling to `wasm32-wasi` you can also enable the `prettyprint` feature if you patch `prettytable-rs` in your `Cargo.toml`:
   
   ```toml
   [patch.crates-io]
   prettytable-rs = { git = "https://github.com/phsym/prettytable-rs", branch = "master"}
   ```
   
   This is mentioned in polars but I'm not sure if this fits the arrow README so I didn't include it.  The arrow2 project recently changed to comfy-table because prettytable-rs is not maintained (see https://github.com/jorgecarleitao/arrow2/pull/251). I don't think that comfy-table compiles to wasm32-wasi but that's minor for now. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684733998



##########
File path: arrow/README.md
##########
@@ -59,11 +59,13 @@ println!("{:?}", array.value(1));
 
 ## Building for WASM
 
-In order to compile Arrow for Web Assembly (the `wasm32-unknown-unknown` WASM target), you will likely need to turn off this crate's default features and use the `js` feature.
+Arrow can compile to WebAssembly using the `wasm32-unknown-unknown` and `wasm32-wasi` targets.

Review comment:
       We can accommodate it when there's demand




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] houqp commented on pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#issuecomment-894840877


   > @nevi-me / @houqp / @roee88 -- do you think this is a change that we should include in arrow-rs 5.2.0 (I plan to create the release candidate this Thursday or Friday) or should we wait for arrow-rs 6.0.0?
   
   Looks like something we should wait for 6.0.0 since removing `js` feature is a breaking change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] roee88 commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
roee88 commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684725663



##########
File path: .github/workflows/rust.yml
##########
@@ -327,12 +327,14 @@ jobs:
           rustup override set ${{ matrix.rust }}
           rustup component add rustfmt
           rustup target add wasm32-unknown-unknown
+          rustup target add wasm32-wasi
       - name: Build arrow crate
         run: |
           export CARGO_HOME="/github/home/.cargo"
           export CARGO_TARGET_DIR="/github/home/target"
           cd arrow
-          cargo build --features=js --target wasm32-unknown-unknown
+          cargo build --no-default-features --features=csv,ipc,simd --target wasm32-unknown-unknown
+          cargo build --no-default-features --features=csv,ipc,simd --target wasm32-wasi

Review comment:
       Specifically for `wasm32-wasi` there is no real need to exclude test dependencies so `cargo build --features=simd --target wasm32-wasi` or `cargo build --target wasm32-wasi` also work.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter commented on pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#issuecomment-894754180


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#674](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e099b23) into [master](https://codecov.io/gh/apache/arrow-rs/commit/b682ef5f058433ea90af47fc016eccf7f356a622?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b682ef5) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/674/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #674      +/-   ##
   ==========================================
   - Coverage   82.42%   82.42%   -0.01%     
   ==========================================
     Files         168      168              
     Lines       47250    47250              
   ==========================================
   - Hits        38948    38947       -1     
   - Misses       8302     8303       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow/src/array/equal\_json.rs](https://codecov.io/gh/apache/arrow-rs/pull/674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsX2pzb24ucnM=) | `84.92% <0.00%> (-0.29%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b682ef5...e099b23](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] nevi-me commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684732620



##########
File path: arrow/README.md
##########
@@ -59,11 +59,13 @@ println!("{:?}", array.value(1));
 
 ## Building for WASM
 
-In order to compile Arrow for Web Assembly (the `wasm32-unknown-unknown` WASM target), you will likely need to turn off this crate's default features and use the `js` feature.
+Arrow can compile to WebAssembly using the `wasm32-unknown-unknown` and `wasm32-wasi` targets.
+
+In order to compile Arrow for `wasm32-unknown-unknown` you will need to exclude test dependencies (the `test_utils` feature). For example, use this snippet in your `Cargo.toml`:
 
 ```toml
 [dependencies]
-arrow = { version = "5.0", default-features = false, features = ["js"] }
+arrow = { version = "5.0", default-features = false, features = ["csv", "ipc", "simd"] }

Review comment:
       This doesn't clearly articulate what's happening, compared to what's being changed. How about:
   
   "In order to compile Arrow for `wasm32-unknown-unknown` you will need to disable default features, then include the desired features, but exclude test dependencies (the `test_utils` feature). For example, use this snippet in your `Cargo.toml`:"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] roee88 commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
roee88 commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684733500



##########
File path: arrow/README.md
##########
@@ -59,11 +59,13 @@ println!("{:?}", array.value(1));
 
 ## Building for WASM
 
-In order to compile Arrow for Web Assembly (the `wasm32-unknown-unknown` WASM target), you will likely need to turn off this crate's default features and use the `js` feature.
+Arrow can compile to WebAssembly using the `wasm32-unknown-unknown` and `wasm32-wasi` targets.
+
+In order to compile Arrow for `wasm32-unknown-unknown` you will need to exclude test dependencies (the `test_utils` feature). For example, use this snippet in your `Cargo.toml`:
 
 ```toml
 [dependencies]
-arrow = { version = "5.0", default-features = false, features = ["js"] }
+arrow = { version = "5.0", default-features = false, features = ["csv", "ipc", "simd"] }

Review comment:
       Updated using your suggested text




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] roee88 commented on a change in pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
roee88 commented on a change in pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#discussion_r684733747



##########
File path: arrow/README.md
##########
@@ -59,11 +59,13 @@ println!("{:?}", array.value(1));
 
 ## Building for WASM
 
-In order to compile Arrow for Web Assembly (the `wasm32-unknown-unknown` WASM target), you will likely need to turn off this crate's default features and use the `js` feature.
+Arrow can compile to WebAssembly using the `wasm32-unknown-unknown` and `wasm32-wasi` targets.

Review comment:
       FYI `wasm32-unknown-emscripten` is not supported because of https://github.com/chronotope/chrono/issues/519




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] roee88 commented on pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
roee88 commented on pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#issuecomment-894755852


   > Anyone know what's the reason for including `test_utils` as the one of the default features?
   
   Because `cargo test` will fail without it. I tried to find alternatives but got blocked by https://github.com/rust-lang/cargo/issues/2911. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #674: Make rand an optional dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #674:
URL: https://github.com/apache/arrow-rs/pull/674#issuecomment-894754180


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#674](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df7d0c9) into [master](https://codecov.io/gh/apache/arrow-rs/commit/b682ef5f058433ea90af47fc016eccf7f356a622?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b682ef5) will **increase** coverage by `0.00%`.
   > The diff coverage is `88.88%`.
   
   > :exclamation: Current head df7d0c9 differs from pull request most recent head b9938b2. Consider uploading reports for the commit b9938b2 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/674/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #674   +/-   ##
   =======================================
     Coverage   82.42%   82.43%           
   =======================================
     Files         168      168           
     Lines       47250    47326   +76     
   =======================================
   + Hits        38948    39015   +67     
   - Misses       8302     8311    +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [parquet/src/data\_type.rs](https://codecov.io/gh/apache/arrow-rs/pull/674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZGF0YV90eXBlLnJz) | `77.32% <84.61%> (+0.18%)` | :arrow_up: |
   | [parquet/src/column/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3dyaXRlci5ycw==) | `93.02% <88.05%> (-0.39%)` | :arrow_down: |
   | [parquet/src/arrow/arrow\_writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyLnJz) | `98.06% <100.00%> (+0.02%)` | :arrow_up: |
   | [arrow/src/array/equal\_json.rs](https://codecov.io/gh/apache/arrow-rs/pull/674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsX2pzb24ucnM=) | `84.92% <0.00%> (-0.29%)` | :arrow_down: |
   | [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/674/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `94.48% <0.00%> (-0.20%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b682ef5...b9938b2](https://codecov.io/gh/apache/arrow-rs/pull/674?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org