You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/06 03:16:47 UTC
[GitHub] [dolphinscheduler] ChrisYuan opened a new pull request, #11329: fix typo in docs from Datasource to DataSource
ChrisYuan opened a new pull request, #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329
## Purpose of the pull request
this pr just fix some type in md docs for issue # 11210, I don't want to close the issue so there is a blank between # and 11210.
Future, i will submit another pr including ts and java files when I am sure my pr do not bring in another bugs.
## Brief change log
change "Datasource" to "DataSource" in all markdown docs.
## Verify this pull request
This pull request is code cleanup without any test coverage.
Docs fix do not need any test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ChrisYuan commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1207925249
OKOK, let me do it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1238849396
> I rebase the pr and resolve the conflicts, need a review, thanks very much~
@ChrisYuan CI indicates that there are some errors in front-end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ChrisYuan commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1207744295
Oh ok, I can push changes to this pr for Java and ts files, it is simple for markdown so I push a quick pr for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ChrisYuan commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1236365826
> There are conflicts to be resolved. Could you plz rebase your code? Thanks @ChrisYuan
> BTW, if you don't want to close the related issue with this PR, you could still use `related: #xxxxxx` to automatically link this PR to the issue instead of using `space` between `#` and `issue number`.
I see, keep doing this, thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ChrisYuan commented on a diff in pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on code in PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#discussion_r967751182
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DataSourceUser.java:
##########
@@ -58,4 +58,64 @@ public class DatasourceUser {
* update time
*/
private Date updateTime;
+
+ public int getId() {
+ return id;
+ }
+
+ public void setId(int id) {
+ this.id = id;
+ }
+
+ public int getUserId() {
+ return userId;
+ }
+
+ public void setUserId(int userId) {
+ this.userId = userId;
+ }
+
+ public int getDataSourceId() {
+ return datasourceId;
+ }
+
+ public void setDataSourceId(int datasourceId) {
+ this.datasourceId = datasourceId;
+ }
+
+ public int getPerm() {
+ return perm;
+ }
+
+ public void setPerm(int perm) {
+ this.perm = perm;
+ }
+
+ public Date getCreateTime() {
+ return createTime;
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1236365528
BTW, if you don't want to close the related issue with this PR, you could still use `related: #xxxxxx` to automatically link this PR to the issue instead of using `space` between `#` and `issue number`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1236364856
There are conflicts to be resolved. Could you plz rebase your code? Thanks @ChrisYuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#discussion_r967746031
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SqoopParameters.java:
##########
@@ -223,13 +223,13 @@ public ResourceParametersHelper getResources() {
}
SourceMysqlParameter sourceMysqlParameter = JSONUtils.parseObject(this.getSourceParams(), SourceMysqlParameter.class);
- if (sourceMysqlParameter.getSrcDatasource() != 0) {
- resources.put(ResourceType.DATASOURCE, sourceMysqlParameter.getSrcDatasource());
+ if (sourceMysqlParameter.getSrcDataSource() != 0) {
+ resources.put(ResourceType.DATASOURCE, sourceMysqlParameter.getSrcDataSource());
}
TargetMysqlParameter targetMysqlParameter = JSONUtils.parseObject(this.getTargetParams(), TargetMysqlParameter.class);
- if (targetMysqlParameter.getTargetDatasource() != 0) {
- resources.put(ResourceType.DATASOURCE, targetMysqlParameter.getTargetDatasource());
+ if (targetMysqlParameter.getTargetDataSource() != 0) {
+ resources.put(ResourceType.DATASOURCE, targetMysqlParameter.getTargetDataSource());
Review Comment:
You can't do this change directly, this will bring an upgrade issue, the parameter has been store at database, user need to refresh their database.
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DataSourceUser.java:
##########
@@ -58,4 +58,64 @@ public class DatasourceUser {
* update time
*/
private Date updateTime;
+
+ public int getId() {
+ return id;
+ }
+
+ public void setId(int id) {
+ this.id = id;
+ }
+
+ public int getUserId() {
+ return userId;
+ }
+
+ public void setUserId(int userId) {
+ this.userId = userId;
+ }
+
+ public int getDataSourceId() {
+ return datasourceId;
+ }
+
+ public void setDataSourceId(int datasourceId) {
+ this.datasourceId = datasourceId;
+ }
+
+ public int getPerm() {
+ return perm;
+ }
+
+ public void setPerm(int perm) {
+ this.perm = perm;
+ }
+
+ public Date getCreateTime() {
+ return createTime;
Review Comment:
You don't need to add `get`, `set` and `toString` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix typo in docs from Datasource to DataSource [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11329: fix typo in docs from Datasource to DataSource
URL: https://github.com/apache/dolphinscheduler/pull/11329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ChrisYuan commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1241370973
> > I rebase the pr and resolve the conflicts, need a review, thanks very much~
>
> @ChrisYuan CI indicates that there are some errors in front-end.
OpsðŸ˜, may need more test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1208963706
>
Oh, I forget to flush the page and not see this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix typo in docs from Datasource to DataSource [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1767391571
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix typo in docs from Datasource to DataSource [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1756495182
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1207746134
> Oh ok, I can push changes to this pr for Java and ts files, it is simple for markdown so I push a quick pr for them.
Got it, but I still suggest fixing them in this PR. It is hard to track and does not make too much sense if we separate a typo-fix PR into two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1207738877
Hi @ChrisYuan , may I ask what is the specific reason you want to fix `ts` and `java` files in a separate PR? IMHO you could add another commit to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ChrisYuan commented on pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ChrisYuan commented on PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#issuecomment-1238806919
I rebase the pr and resolve the conflicts, need a review, thanks very much~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11329: fix typo in docs from Datasource to DataSource
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#discussion_r967746031
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SqoopParameters.java:
##########
@@ -223,13 +223,13 @@ public ResourceParametersHelper getResources() {
}
SourceMysqlParameter sourceMysqlParameter = JSONUtils.parseObject(this.getSourceParams(), SourceMysqlParameter.class);
- if (sourceMysqlParameter.getSrcDatasource() != 0) {
- resources.put(ResourceType.DATASOURCE, sourceMysqlParameter.getSrcDatasource());
+ if (sourceMysqlParameter.getSrcDataSource() != 0) {
+ resources.put(ResourceType.DATASOURCE, sourceMysqlParameter.getSrcDataSource());
}
TargetMysqlParameter targetMysqlParameter = JSONUtils.parseObject(this.getTargetParams(), TargetMysqlParameter.class);
- if (targetMysqlParameter.getTargetDatasource() != 0) {
- resources.put(ResourceType.DATASOURCE, targetMysqlParameter.getTargetDatasource());
+ if (targetMysqlParameter.getTargetDataSource() != 0) {
+ resources.put(ResourceType.DATASOURCE, targetMysqlParameter.getTargetDataSource());
Review Comment:
You can't do this change directly, this will bring an upgrade issue, the parameter has been store at database, user need to refresh their history data in database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org