You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2017/01/07 10:13:55 UTC

Re: Review Request 52728: Renamed `inspect` to `inspectContainer`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52728/
-----------------------------------------------------------

(Updated \u4e00\u6708 7, 2017, 10:13 a.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
-------

Rebase


Bugs: MESOS-5967
    https://issues.apache.org/jira/browse/MESOS-5967


Repository: mesos


Description
-------

We introduced `inspectImage` for docker containerizer, and it is
better rename current `inspect` to `inspectContainer` to keep
consistent.


Diffs (updated)
-----

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 
  src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7 
  src/slave/constants.hpp 1159ac3b1f8797a847a6f5679045434064a519e9 
  src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6 
  src/tests/containerizer/docker_containerizer_tests.cpp 4e3b67bbb989f9084dfdf4970839956dcb0caa0e 
  src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd 
  src/tests/mock_docker.hpp 829a760d54ad8c7b88256ae5df4c88c9fb18df71 
  src/tests/mock_docker.cpp 02b6065a01e7e52b0edb38676dfb1bb475584502 

Diff: https://reviews.apache.org/r/52728/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu