You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/29 18:25:10 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #6952: [AIRFLOW-4445]
mushroom cloud errors too verbose
tooptoop4 opened a new pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6952: [AIRFLOW-4445] mushroom
cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569536689
Thanks @tooptoop4! One more request. Would you be so kind to update the AIRFLOW-XXX in the template (as requested in the template itself) of the PR to point to the right issue? It makes it a bit easier to resolve an issue after merging it (one-click from the description). We will soon add probot and we will be able to automate this part but until we have it, it would be great PR submitters do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bf29ef3286bc27df66b6f3ad42d19c56fd14e115?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [bf29ef3...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [7d97d16...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/7d97d16c47ba181839fd583b8653d2872dc4290b?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [7d97d16...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#discussion_r362102402
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -324,6 +324,12 @@ error_logfile = -
# Expose the configuration file in the web server
expose_config = False
+# Expose hostname in the web server
+expose_hostname = True
Review comment:
Can you add some documentation about this option? If there is no information about this feature in the documentation, very few people will be able to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bf29ef3286bc27df66b6f3ad42d19c56fd14e115?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [bf29ef3...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6952: [AIRFLOW-4445]
mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bf29ef3286bc27df66b6f3ad42d19c56fd14e115?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [bf29ef3...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bf29ef3286bc27df66b6f3ad42d19c56fd14e115?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [bf29ef3...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#discussion_r362111591
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -324,6 +324,12 @@ error_logfile = -
# Expose the configuration file in the web server
expose_config = False
+# Expose hostname in the web server
+expose_hostname = True
Review comment:
A similar situation took place with the guides for operators. Initially, we only had one file that contained a description of all operators. However, at some point, we refactored the documentation to create a new quality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6952: [AIRFLOW-4445]
mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569537616
ok!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6952: [AIRFLOW-4445] mushroom
cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569538789
BTW. Just proposed to simplify it in #6955 - feel free to comment :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bf29ef3286bc27df66b6f3ad42d19c56fd14e115?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [bf29ef3...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#discussion_r362111344
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -324,6 +324,12 @@ error_logfile = -
# Expose the configuration file in the web server
expose_config = False
+# Expose hostname in the web server
+expose_hostname = True
Review comment:
I answered most of your questions in a different thread.:
https://github.com/apache/airflow/pull/6923#discussion_r362110552
I think we can add new section in `security.rst`file. This file is long and suitable for refactoring, but I think we should do it in a separate PR. Please note that refactoring documentation, which is even a collection of random guides, is simpler than writing all documentation from scratch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#discussion_r362108536
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -324,6 +324,12 @@ error_logfile = -
# Expose the configuration file in the web server
expose_config = False
+# Expose hostname in the web server
+expose_hostname = True
Review comment:
@mik-laj - > where do you think the documentation should be added ? Maybe you can provide some pointers? Most of the config options are documented in comments of the default_airlfow.cfg. Any other specific place you think this documentation should be added (and where all the previous options are documented?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6952: [AIRFLOW-4445] mushroom
cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#discussion_r362175923
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -324,6 +324,12 @@ error_logfile = -
# Expose the configuration file in the web server
expose_config = False
+# Expose hostname in the web server
+expose_hostname = True
Review comment:
@tooptoop4 -> would you be so kind to add this in the doc section as explained by @mik-laj ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6952: [AIRFLOW-4445] mushroom
cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569530371
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6952:
[AIRFLOW-4445] mushroom cloud errors too verbose
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6952: [AIRFLOW-4445] mushroom cloud errors too verbose
URL: https://github.com/apache/airflow/pull/6952#issuecomment-569533300
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=h1) Report
> Merging [#6952](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bf29ef3286bc27df66b6f3ad42d19c56fd14e115?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6952 +/- ##
=========================================
- Coverage 84.7% 84.7% -0.01%
=========================================
Files 680 680
Lines 38556 38556
=========================================
- Hits 32659 32658 -1
- Misses 5897 5898 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <ø> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6952/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=footer). Last update [bf29ef3...0e24de6](https://codecov.io/gh/apache/airflow/pull/6952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services