[GitHub] [hbase] Apache9 commented on a change in pull request #320: HBASE-21879 Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #320: HBASE-21879 Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
URL: https://github.com/apache/hbase/pull/320#discussion_r295304908
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyServerRpcConnection.java
 ##########
 @@ -59,12 +59,7 @@
 
   void process(final ByteBuf buf) throws IOException, InterruptedException {
     if (connectionHeaderRead) {
-      this.callCleanup = new RpcServer.CallCleanup() {
-        @Override
-        public void run() {
-          buf.release();
-        }
-      };
+      this.callCleanup = buf::release;
 
 Review comment:
   Tricky :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services