You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/10/02 18:15:03 UTC

[GitHub] githublaohu opened a new pull request #485: Develop acl

githublaohu opened a new pull request #485: Develop acl
URL: https://github.com/apache/rocketmq/pull/485
 
 
   ## What is the purpose of the change
   Many users provide feedback that RocketMQ can't manage or protect RocketMQ resources effectively in complex development , testing,text
   许多用户反馈RocketMQ在复杂的开发,测试等环境中无法有效的管理并且保护好RocketMQ资源。十分盼望RocketMQ拥有ACL体系
   
   ## Brief changelog
   Look at the acl-plug module.
   Look at the rocketmq\distribution\conf\transport.yml file.
   
   ## Verifying this change
   1. broker configuration files Join the 
   aclPlug=true
   2. change distribution\conf\transport.yml file
   onlyNetAddress is no password required 。Forward compatibility
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [y] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [y ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services