You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/13 02:25:49 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7298: install qemu on docker
xiaoxiang781216 commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r994047320
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
+# Build image for qemu
+###############################################################################
+#FROM qemu
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build
+# Download qemu and install
+RUN mkdir qemu && \
+ #curl -s -L "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
+ wget -c "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
Review Comment:
why not use curl
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
Review Comment:
move to "Base image" section
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
+# Build image for qemu
+###############################################################################
+#FROM qemu
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build
+# Download qemu and install
+RUN mkdir qemu && \
+ #curl -s -L "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
Review Comment:
why not use the latest official release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org