You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Raajay Viswanathan (JIRA)" <ji...@apache.org> on 2015/07/30 22:00:04 UTC

[jira] [Updated] (HIVE-11413) Error in detecting availability of HiveSemanticAnalyzerHooks

     [ https://issues.apache.org/jira/browse/HIVE-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raajay Viswanathan updated HIVE-11413:
--------------------------------------
    Attachment: HIVE-11413.patch

Check if _saHooks_ is empty instead of checking if it is NULL. Need code review.

> Error in detecting availability of HiveSemanticAnalyzerHooks
> ------------------------------------------------------------
>
>                 Key: HIVE-11413
>                 URL: https://issues.apache.org/jira/browse/HIVE-11413
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 2.0.0
>            Reporter: Raajay Viswanathan
>            Assignee: Raajay Viswanathan
>            Priority: Trivial
>              Labels: newbie
>         Attachments: HIVE-11413.patch
>
>
> In {{compile(String, Boolean)}} function in {{Driver.java}}, the list of available {{HiveSemanticAnalyzerHook}} (_saHooks_) are obtained using the {{getHooks}} method. This method always  returns a {{List}} of hooks. 
> However, while checking for availability of hooks, the current version of the code uses a comparison of _saHooks_ with NULL. This is incorrect, as the segment of code designed to call pre and post Analyze functions gets executed even when the list is empty. The comparison should be changed to {{saHooks.size() > 0}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)