[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20932: [FEATURE] Support bfloat and float mixed input in elemwise broadcast ops.

[GitBox <gi...@apache.org>]

bartekkuncer commented on a change in pull request #20932:
URL: https://github.com/apache/incubator-mxnet/pull/20932#discussion_r832251659



##########
File path: src/operator/nn/dnnl/dnnl_binary.cc
##########
@@ -64,12 +64,14 @@ void DNNLBinaryOpFwd::Execute(const std::vector<NDArray>& inputs,
 }
 
 bool SupportDNNLBinary(const std::vector<NDArray>& inputs) {
-  auto dtype  = inputs[0].dtype();
-  auto ndim_0 = inputs[0].shape().ndim();
-  auto ndim_1 = inputs[1].shape().ndim();
+  auto dtype_0 = inputs[0].dtype();
+  auto dtype_1 = inputs[1].dtype();
+  auto ndim_0  = inputs[0].shape().ndim();
+  auto ndim_1  = inputs[1].shape().ndim();
   return ndim_0 >= 1 && ndim_0 <= 6 && ndim_1 >= 1 && ndim_1 <= 6 &&

Review comment:
       Are you sure about this restrictions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org