You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 19:56:37 UTC
[GitHub] [airflow] frodo2000 opened a new pull request #20640: Update operators.rst
frodo2000 opened a new pull request #20640:
URL: https://github.com/apache/airflow/pull/20640
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#discussion_r777720589
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -208,3 +208,21 @@ In this case, ``order_data`` argument is passed: ``{"1001": 301.27, "1002": 433.
Airflow uses Jinja's `NativeEnvironment <https://jinja.palletsprojects.com/en/2.11.x/nativetypes/>`_
when ``render_template_as_native_obj`` is set to ``True``.
With ``NativeEnvironment``, rendering a template produces a native Python type.
+
+.. _concepts:reserved-keywords:
+
+Reserved params keyword
+-----------------------
+
+In Apache Airflow 2.3.3 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
+If you upgrade your environment and get the following error
+
+.. code-block:: python
Review comment:
Does this problem occur with all / most constructor parameters, or only this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frodo2000 commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
frodo2000 commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006063197
@potiuk any idea what Change to satisfy test ? Looks like block parser doesn’t recognize Python error code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006674216
> Solution works. Only Build PROD image is not working currently (not only for my commits).
Ah let me take a look I think this might be an aftermath of a 'too-early" merged PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20640:
URL: https://github.com/apache/airflow/pull/20640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004320989
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frodo2000 commented on a change in pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
frodo2000 commented on a change in pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#discussion_r777703679
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -208,3 +208,21 @@ In this case, ``order_data`` argument is passed: ``{"1001": 301.27, "1002": 433.
Airflow uses Jinja's `NativeEnvironment <https://jinja.palletsprojects.com/en/2.11.x/nativetypes/>`_
when ``render_template_as_native_obj`` is set to ``True``.
With ``NativeEnvironment``, rendering a template produces a native Python type.
+
+.. _concepts:reserved-keywords:
+
+Reserved params keyword
+-----------------------
+
+In Apache Airflow 2.3.3 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
+If you upgrade your environment and get the following error
+
+.. code-block:: python
Review comment:
Problem is placed if you provide self.params variable in your operator code. I know that is no exception handling for that issue (only class different that apache.airflow.params is covered).
You could remove code and provide more reserved words which should not be used in Operators code (as variable name for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006674216
> Solution works. Only Build PROD image is not working currently (not only for my commits).
Ah let me take a look I think this might be an aftermath of a 'too-early" merged commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004321605
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004617492
I noticed one small mistake - suggestion added - also some errors in static checks/building docs require fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006686217
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#discussion_r777701355
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -208,3 +208,21 @@ In this case, ``order_data`` argument is passed: ``{"1001": 301.27, "1002": 433.
Airflow uses Jinja's `NativeEnvironment <https://jinja.palletsprojects.com/en/2.11.x/nativetypes/>`_
when ``render_template_as_native_obj`` is set to ``True``.
With ``NativeEnvironment``, rendering a template produces a native Python type.
+
+.. _concepts:reserved-keywords:
+
+Reserved params keyword
+-----------------------
+
+In Apache Airflow 2.3.3 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
+If you upgrade your environment and get the following error
+
+.. code-block:: python
Review comment:
This error message is too specific to be added to the documentation. If the error message is not understandable enough, we should. update it instead of copying it to the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006686057
We can merge this one. Indeed Production image does not pass the tests (and for a good reason - airflow is missing there!) - but I am working on reproducing and fix it,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004664291
See also #20648 which would change the code example in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004677967
> @uranusjr To be honest - name param for dag serialization is not best option. Maybe you should consider use some more unique like dagSerializationParams?
This ship has sailed I am afraid. There are airflow versions out there that are using it, changing it woudl require a deprecation, so the parameter would not be usable till Airflow 3 anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#discussion_r779558160
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -208,3 +208,22 @@ In this case, ``order_data`` argument is passed: ``{"1001": 301.27, "1002": 433.
Airflow uses Jinja's `NativeEnvironment <https://jinja.palletsprojects.com/en/2.11.x/nativetypes/>`_
when ``render_template_as_native_obj`` is set to ``True``.
With ``NativeEnvironment``, rendering a template produces a native Python type.
+
+.. _concepts:reserved-keywords:
+
+Reserved params keyword
+-----------------------
+
+In Apache Airflow 2.2.0 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
+If you upgrade your environment and get the following error:
+
+.. code-block::
+
+ Broken DAG: [/opt/airflow/dags/ImamRefresh_DAG.py] Traceback (most recent call last):
+ File "/home/airflow/airflow_venv/lib64/python3.6/site-packages/airflow/serialization/serialized_objects.py", line 574, in serialize_operator
+ serialize_op['params'] = cls._serialize_params_dict(op.params)
+ File "/home/airflow/airflow_venv/lib64/python3.6/site-packages/airflow/serialization/serialized_objects.py", line 447, in _serialize_params_dict
+ if f'{v.__module__}.{v.__class__.__name__}' == 'airflow.models.param.Param':
Review comment:
```suggestion
```
I have the impression that only the error message is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frodo2000 commented on a change in pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
frodo2000 commented on a change in pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#discussion_r777728551
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -208,3 +208,21 @@ In this case, ``order_data`` argument is passed: ``{"1001": 301.27, "1002": 433.
Airflow uses Jinja's `NativeEnvironment <https://jinja.palletsprojects.com/en/2.11.x/nativetypes/>`_
when ``render_template_as_native_obj`` is set to ``True``.
With ``NativeEnvironment``, rendering a template produces a native Python type.
+
+.. _concepts:reserved-keywords:
+
+Reserved params keyword
+-----------------------
+
+In Apache Airflow 2.3.3 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
+If you upgrade your environment and get the following error
+
+.. code-block:: python
Review comment:
I found it only for one Operator with internal params variable. Most of my operators works correctly after migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#discussion_r777904597
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -208,3 +208,21 @@ In this case, ``order_data`` argument is passed: ``{"1001": 301.27, "1002": 433.
Airflow uses Jinja's `NativeEnvironment <https://jinja.palletsprojects.com/en/2.11.x/nativetypes/>`_
when ``render_template_as_native_obj`` is set to ``True``.
With ``NativeEnvironment``, rendering a template produces a native Python type.
+
+.. _concepts:reserved-keywords:
+
+Reserved params keyword
+-----------------------
+
+In Apache Airflow 2.3.3 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
+If you upgrade your environment and get the following error
+
+.. code-block:: python
Review comment:
I tihnk `params` is quite likely name that will be used by custom operators, so having a warning against this one (and the fact that it has been **just** added make it more likely for people to get the same problem.
Simply - operators that worked in 2.1 will stop working in 2.2 - which is kinda unexpected. So I think this message is useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#discussion_r777904770
##########
File path: docs/apache-airflow/concepts/operators.rst
##########
@@ -208,3 +208,21 @@ In this case, ``order_data`` argument is passed: ``{"1001": 301.27, "1002": 433.
Airflow uses Jinja's `NativeEnvironment <https://jinja.palletsprojects.com/en/2.11.x/nativetypes/>`_
when ``render_template_as_native_obj`` is set to ``True``.
With ``NativeEnvironment``, rendering a template produces a native Python type.
+
+.. _concepts:reserved-keywords:
+
+Reserved params keyword
+-----------------------
+
+In Apache Airflow 2.3.3 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
Review comment:
```suggestion
In Apache Airflow 2.2.0 ``params`` variable is used during DAG serialization. Please do not use that name in third party operators.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004677967
> @uranusjr To be honest - name param for dag serialization is not best option. Maybe you should consider use some more unique like dagSerializationParams?
This ship has sailed I am afraid. There are airflow versions out there that are using it, changing it woudl require a deprecation, so the parameter would not be usable till 2.3 anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006538232
> @potiuk any idea what Change to satisfy test ? Looks like block parser doesn’t recognize Python error code
The code is not python - remove "python". Sphinx fails when you mark code as "pyhon" because it cannot parse it.
The "python" code-block expects actual parseable Python code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006538232
> @potiuk any idea what Change to satisfy test ? Looks like block parser doesn’t recognize Python error code
The code is not python - remove "python". Sphinx fails when you mark code as "pyhon" because it cannot parse it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frodo2000 closed pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
frodo2000 closed pull request #20640:
URL: https://github.com/apache/airflow/pull/20640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frodo2000 commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
frodo2000 commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004669103
@uranusjr To be honest - name param for dag serialization is not best option. Maybe you should consider use some more unique like dagSerializationParams?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frodo2000 commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
frodo2000 commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1006672192
> > @potiuk any idea what Change to satisfy test ? Looks like block parser doesn’t recognize Python error code
>
> The code is not python - remove "python". Sphinx fails when you mark code as "pyhon" because it cannot parse it.
>
> The "python" code-block expects actual parseable Python code :)
Solution works. Only Build PROD image is not working currently (not only for my commits).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20640: Update operators.rst
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20640:
URL: https://github.com/apache/airflow/pull/20640#issuecomment-1004321735
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org