You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Bill Bell (JIRA)" <ji...@apache.org> on 2011/01/27 10:01:43 UTC
[jira] Created: (SOLR-2337) Solr needs hits= added to the log when
using grouping
Solr needs hits= added to the log when using grouping
------------------------------------------------------
Key: SOLR-2337
URL: https://issues.apache.org/jira/browse/SOLR-2337
Project: Solr
Issue Type: Bug
Components: SearchComponents - other
Affects Versions: 4.0
Reporter: Bill Bell
We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
When using group=true, hits= does not show up:
{code}
2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
{code}
The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
It does return hits= in the log for mainResult, but not for standard grouping.
This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073426#comment-13073426 ]
Bill Bell commented on SOLR-2337:
---------------------------------
MArtin,
Are you logging it in your latest patch?
If so, we can close this. We use the info in the log to try to find queries where users get 0 results, and we are using grouping exclusively.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005514#comment-13005514 ]
Bill Bell commented on SOLR-2337:
---------------------------------
Can a committer please look at my patch?
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2337) Solr needs hits= added to the log when
using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2337:
----------------------------
Attachment: SOLR.2337.patch
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004379#comment-13004379 ]
Bill Bell commented on SOLR-2337:
---------------------------------
I found a quick fix that will output # of hits. See attached patch,
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Attachments: SOLR.2377.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Closed] (SOLR-2337) Solr needs hits= added to the log when
using grouping
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen closed SOLR-2337.
---------------------------------------
Resolution: Fixed
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048287#comment-13048287 ]
Martijn van Groningen commented on SOLR-2337:
---------------------------------------------
In SOLR-2564 when group.totalCount=GROUPED is specified the total number of groups is added inside a ngroups element. The number of documents that have matched is always placed inside the matches element.
The semantics changed a bit. Matches always represent the number of documents that have matched the main query. The ngroups represent the number of groups per groupby command (field, func and query).
So currently in SOLR-2564 the count in the log file always reflects the number of documents that have matched the query.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006330#comment-13006330 ]
Bill Bell commented on SOLR-2337:
---------------------------------
The only downfall with this patch, is the hits=10 means the following:
1. if there are 20 rows that match and are grouped, and if rows=10 then hits will be 10 (since the short circuit) is still obeyed. Otherwise there could be a performance issue with looping until end of results.
2. if there are 4 rows that match and are grouped, and you say rows=10, hits will be 4 (normal behavior).
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073447#comment-13073447 ]
Martijn van Groningen commented on SOLR-2337:
---------------------------------------------
Yes the trunk and branch3x do log the request when using grouping.
The number of matches of the first command is actually logged now.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Reopened: (SOLR-2337) Solr needs hits= added to the log when
using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell reopened SOLR-2337:
-----------------------------
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2377.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2337) Solr needs hits= added to the log when
using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell resolved SOLR-2337.
-----------------------------
Resolution: Fixed
Fix Version/s: 4.0
Ready for committer
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2377.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-2337) Solr needs hits= added to
the log when using grouping
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047931#comment-13047931 ]
Martijn van Groningen edited comment on SOLR-2337 at 6/11/11 4:01 PM:
----------------------------------------------------------------------
bq. I assume the matches would work for the group.totalCount=GROUPED or UNGROUPED.
This will work in both of these cases in the latest patch in SOLR-2564. It will always log the number of matches, not the number of groups.
was (Author: martijn.v.groningen):
bq. I assume the matches would work for the group.totalCount=GROUPED or UNGROUPED.
This will work in both of these cases. It will always log the number of matches, not the number of groups.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047911#comment-13047911 ]
Martijn van Groningen commented on SOLR-2337:
---------------------------------------------
Hi Bill, I think we can just get the matches from the first *Command and then add that to the log. The matches is the same for each command.
I will add this to SOLR-2564, this will be backported to SOLR-2524.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2337) Solr needs hits= added to the log when
using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2337:
----------------------------
Comment: was deleted
(was: Ready for committer)
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Issue Comment Edited: (SOLR-2337) Solr needs hits= added to
the log when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006330#comment-13006330 ]
Bill Bell edited comment on SOLR-2337 at 3/14/11 3:24 PM:
----------------------------------------------------------
There is one terminology issue with this patch:
1. If there are 20 rows that match your query and are grouped, and if rows=10, then hits will be 10 (since the code does not loop through all results to short circuit and speed up the results). Otherwise there could be a performance issue with looping until end of results. FWIW, the number of matches could be thought of as hits, just not for this use case.
2. As normal, if there are 4 rows that match and are grouped, and you say rows=10, hits will be 4 (normal behavior).
was (Author: billnbell):
There is one terminology issue with this patch:
1. If there are 20 rows that match your query and are grouped, and if rows=10, then hits will be 10 (since the code does not loop through all results to short circuit and speed up the results). Otherwise there could be a performance issue with looping until end of results.
2. As normal, if there are 4 rows that match and are grouped, and you say rows=10, hits will be 4 (normal behavior).
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047929#comment-13047929 ]
Bill Bell commented on SOLR-2337:
---------------------------------
Having matches is very useful. I am good with that.
I assume the matches would work for the group.totalCount=GROUPED or UNGROUPED.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2337) Solr needs hits= added to the log when
using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2337:
----------------------------
Attachment: (was: SOLR.2377.patch)
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2337) Solr needs hits= added to the log when
using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2337:
----------------------------
Attachment: SOLR.2377.patch
Patch to add hits to group by
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Attachments: SOLR.2377.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Martijn van Groningen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047931#comment-13047931 ]
Martijn van Groningen commented on SOLR-2337:
---------------------------------------------
bq. I assume the matches would work for the group.totalCount=GROUPED or UNGROUPED.
This will work in both of these cases. It will always log the number of matches, not the number of groups.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2337) Solr needs hits= added to the log
when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048270#comment-13048270 ]
Bill Bell commented on SOLR-2337:
---------------------------------
I am not understanding this.
When I set group.totalCount=GROUPED the XML sets matches=<the number of groups>.
Are you saying the log file will not reflect the value in the XML and always use the UNGROUPED value?
Thanks.
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Issue Comment Edited: (SOLR-2337) Solr needs hits= added to
the log when using grouping
Posted by "Bill Bell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006330#comment-13006330 ]
Bill Bell edited comment on SOLR-2337 at 3/14/11 3:23 PM:
----------------------------------------------------------
There is one terminology issue with this patch:
1. If there are 20 rows that match your query and are grouped, and if rows=10, then hits will be 10 (since the code does not loop through all results to short circuit and speed up the results). Otherwise there could be a performance issue with looping until end of results.
2. As normal, if there are 4 rows that match and are grouped, and you say rows=10, hits will be 4 (normal behavior).
was (Author: billnbell):
The only downfall with this patch, is the hits=10 means the following:
1. if there are 20 rows that match and are grouped, and if rows=10 then hits will be 10 (since the short circuit) is still obeyed. Otherwise there could be a performance issue with looping until end of results.
2. if there are 4 rows that match and are grouped, and you say rows=10, hits will be 4 (normal behavior).
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp= path=/select params={group=true&group.field=gender&group.field=id&q=*:*} status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org