You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2007/08/28 06:08:52 UTC
DO NOT REPLY [Bug 43222] New: - [PATCH] Support for getting OLE objects from HSSFWorkbook
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
Summary: [PATCH] Support for getting OLE objects from
HSSFWorkbook
Product: POI
Version: 3.0-dev
Platform: Other
OS/Version: other
Status: NEW
Keywords: PatchAvailable
Severity: enhancement
Priority: P2
Component: HSSF
AssignedTo: dev@poi.apache.org
ReportedBy: trejkaz@trypticon.org
Added support for the sub-record which stores the embedded object IDs. Added
usermodel API for getting access to the embedded object's data.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43222] - [PATCH] Support for getting OLE objects from HSSFWorkbook
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
------- Additional Comments From trejkaz@trypticon.org 2007-08-27 21:17 -------
Created an attachment (id=20717)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20717&action=view)
Test file for OLE2 embedding in an XLS file.
Attaching test file.
Unit test code: (there is a tiny amount of our framework in it to locate the
file, should be easily removed.
/**
* Tests that embedded objects are accessible.
*
* @throws Exception if an error occurs.
*/
public void testEmbeddedObjects() throws Exception
{
File file = getDataFile("office/ole2-embedding.xls");
HSSFWorkbook workbook = new HSSFWorkbook(new FileInputStream(file));
List objects = workbook.getAllEmbeddedObjects();
assertEquals("Wrong number of objects", 2, objects.size());
assertEquals("Wrong name for first object", "MBD06CAB431",
((HSSFObjectData)
objects.get(0)).getDirectory().getName());
assertEquals("Wrong name for second object", "MBD06CAC85A",
((HSSFObjectData)
objects.get(1)).getDirectory().getName());
}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43222] - Support for getting OLE objects from HSSFWorkbook
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
trejkaz@trypticon.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20716|0 |1
is obsolete| |
------- Additional Comments From trejkaz@trypticon.org 2007-08-29 18:34 -------
Created an attachment (id=20734)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20734&action=view)
Patch version 2
Here's the fixed version... it doesn't break the sheets, and is simpler than
the original anyway.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43222] - [PATCH] Support for getting OLE objects from HSSFWorkbook
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
------- Additional Comments From yegor@dinom.ru 2007-09-08 09:40 -------
Patch applied. Thanks for it.
I will not close this bug for the same reason as Bug 43222 - it lacks unit tests.
Please provide at least a unit test for EmbeddedObjectRefSubRecord.
Also, dropping a line in the HSSF quick guide won't harm.
Regards,
Yegor
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43222] - [PATCH] Support for getting OLE objects from HSSFWorkbook
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
yegor@dinom.ru changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From yegor@dinom.ru 2008-01-24 23:11 -------
Unit tests were added. The bug can be closed.
Yegor
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43222] - [PATCH] Support for getting OLE objects from HSSFWorkbook
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
------- Additional Comments From trejkaz@trypticon.org 2007-08-27 21:09 -------
Created an attachment (id=20716)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20716&action=view)
Patch to add embedded object support to HSSF
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43222] - Support for getting OLE objects from HSSFWorkbook
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
trejkaz@trypticon.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|PatchAvailable |
Summary|[PATCH] Support for getting |Support for getting OLE
|OLE objects from |objects from HSSFWorkbook
|HSSFWorkbook |
------- Additional Comments From trejkaz@trypticon.org 2007-08-29 18:09 -------
Turns out this breaks something else, working on version 2.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43222] - [PATCH] Support for getting OLE objects from HSSFWorkbook
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43222>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43222
trejkaz@trypticon.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
Summary|Support for getting OLE |[PATCH] Support for getting
|objects from HSSFWorkbook |OLE objects from
| |HSSFWorkbook
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org