[GitHub] [spark] amaliujia edited a comment on pull request #35550: [SPARK-38238][SQL]Contains Join for Spark SQL

[GitBox <gi...@apache.org>]

amaliujia edited a comment on pull request #35550:
URL: https://github.com/apache/spark/pull/35550#issuecomment-1045138143


   I would suggest to discuss this idea with experienced people. For example you can write an email to dev@ to demonstrate your idea, collect feedback, etc. Another idea is that it will also be useful to build macro benchmarks to verify the improvement. The macro benchmark can be very simple: a for loop run query with prepared in-memory data, before and after the change, with a timer to count the time. The improved runtime can justify the idea as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org