You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Herbert Duerr <hd...@apache.org> on 2012/08/01 15:53:40 UTC
Re: [Call-for-Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers
On 25.07.2012 07:11, Zhang Lu wrote:
> One fix for review.
>
> https://issues.apache.org/ooo/show_bug.cgi?id=93128
>[...]
> Root cause: There is no flow to handle a real number when selecting string
> length operation
>
> Solution: if operation is string length type, to get the number's length,
> and consider it as a string.
Great! I reviewed, tested and applied your patch.
Herbert
Re: [Call-for-Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers
Posted by Lei Wang <le...@gmail.com>.
Herbert, thank you for applying the patch. I planed to do it. But after
merging this patch and updating to latest trunk code, I can not build trunk
successfully for several days.
On Wed, Aug 1, 2012 at 9:53 PM, Herbert Duerr <hd...@apache.org> wrote:
> On 25.07.2012 07:11, Zhang Lu wrote:
>
>> One fix for review.
>>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=93128<https://issues.apache.org/ooo/show_bug.cgi?id=93128>
>> [...]
>>
>> Root cause: There is no flow to handle a real number when selecting string
>> length operation
>>
>> Solution: if operation is string length type, to get the number's length,
>> and consider it as a string.
>>
>
> Great! I reviewed, tested and applied your patch.
>
> Herbert
>