You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/07/11 22:58:58 UTC
[GitHub] [airflow] potiuk opened a new pull request, #32532: Add executors discovery to providers
potiuk opened a new pull request, #32532:
URL: https://github.com/apache/airflow/pull/32532
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260386650
##########
airflow/providers_manager.py:
##########
@@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None:
if _sanity_check(provider_package, auth_backend_module_name + ".init_app", provider):
self._api_auth_backend_module_names.add(auth_backend_module_name)
+ def _discover_executors(self) -> None:
+ """Retrieve all executors defined in the providers."""
+ for provider_package, provider in self._provider_dict.items():
+ if provider.data.get("executors"):
+ for executors_class_name in provider.data["executors"]:
+ if _sanity_check(provider_package, executors_class_name, provider):
Review Comment:
Out of scope, but we should likely rename that method at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32532: Add Executors discovery and documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32532:
URL: https://github.com/apache/airflow/pull/32532#issuecomment-1631613546
Based on #32526, so only last commit counts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260389295
##########
airflow/providers_manager.py:
##########
@@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None:
if _sanity_check(provider_package, auth_backend_module_name + ".init_app", provider):
self._api_auth_backend_module_names.add(auth_backend_module_name)
Review Comment:
Out of scope, but this file looks like it is begging for a helper method. :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260684817
##########
docs/exts/operators_and_hooks_ref.py:
##########
@@ -284,12 +284,32 @@ def _prepare_notifications_data():
return all_notifiers
+def _prepare_executors_data():
+ package_data = load_package_data()
+ all_executors = {}
+ for provider in package_data:
+ executors = provider.get("executors")
+ if executors:
Review Comment:
Indeed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260383267
##########
airflow/providers/celery/executors/__init__.py:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import packaging.version
+
+from airflow.exceptions import AirflowOptionalProviderFeatureException
+
+try:
+ from airflow import __version__ as airflow_version
+except ImportError:
+ from airflow.version import version as airflow_version
+
+base_version = packaging.version.parse(airflow_version).base_version
Review Comment:
Maybe not, that would result in a super long and convoluted line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260683972
##########
airflow/providers_manager.py:
##########
@@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None:
if _sanity_check(provider_package, auth_backend_module_name + ".init_app", provider):
self._api_auth_backend_module_names.add(auth_backend_module_name)
+ def _discover_executors(self) -> None:
+ """Retrieve all executors defined in the providers."""
+ for provider_package, provider in self._provider_dict.items():
+ if provider.data.get("executors"):
+ for executors_class_name in provider.data["executors"]:
+ if _sanity_check(provider_package, executors_class_name, provider):
Review Comment:
Yes. NOW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260383267
##########
airflow/providers/celery/executors/__init__.py:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import packaging.version
+
+from airflow.exceptions import AirflowOptionalProviderFeatureException
+
+try:
+ from airflow import __version__ as airflow_version
+except ImportError:
+ from airflow.version import version as airflow_version
+
+base_version = packaging.version.parse(airflow_version).base_version
Review Comment:
Maybe not, that would result in a super long line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260394523
##########
docs/exts/operators_and_hooks_ref.py:
##########
@@ -284,12 +284,32 @@ def _prepare_notifications_data():
return all_notifiers
+def _prepare_executors_data():
+ package_data = load_package_data()
+ all_executors = {}
+ for provider in package_data:
+ executors = provider.get("executors")
+ if executors:
Review Comment:
Unleash the walrus?
```suggestion
if (executors := provider.get("executors")):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260394523
##########
docs/exts/operators_and_hooks_ref.py:
##########
@@ -284,12 +284,32 @@ def _prepare_notifications_data():
return all_notifiers
+def _prepare_executors_data():
+ package_data = load_package_data()
+ all_executors = {}
+ for provider in package_data:
+ executors = provider.get("executors")
+ if executors:
Review Comment:
Unleash the walrus?
```suggestion
if (executors := provider.get("executors")):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260684490
##########
airflow/providers_manager.py:
##########
@@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None:
if _sanity_check(provider_package, auth_backend_module_name + ".init_app", provider):
self._api_auth_backend_module_names.add(auth_backend_module_name)
Review Comment:
Yeah. Likely a nice refactor would be nice here. But separately from this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1261828071
##########
airflow/provider_info.schema.json:
##########
@@ -71,13 +71,20 @@
"type": "string"
}
},
- "notifications": {
+ "notifications": {
"type": "array",
"description": "Notification class names",
"items": {
"type": "string"
}
- },
+ },
+ "executors": {
Review Comment:
Niiice, I know I'm late to this PR but this is great! I was planning on adding a section to the schema exactly like this when we're ready to land our first AWS executor. Thanks for beating us to it @potiuk :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1261542429
##########
scripts/in_container/verify_providers.py:
##########
@@ -714,12 +714,17 @@ def run_provider_discovery():
subprocess.run(["airflow", "providers", "secrets"], check=True)
console.print("[bright_blue]List all auth backends[/]\n")
subprocess.run(["airflow", "providers", "auth"], check=True)
- if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.7.0.dev0"):
+ if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.6.0.dev0"):
# CI also check if our providers are installable and discoverable in airflow older versions
# But the triggers command is not available till airflow-2-6-0
# TODO: Remove this block once airflow dependency in providers are > 2-6-0
console.print("[bright_blue]List all triggers[/]\n")
subprocess.run(["airflow", "providers", "triggers"], check=True)
+ if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.7.0.dev0"):
+ # CI also check if our providers are installable and discoverable in airflow older versions
+ # But the triggers command is not available till airflow-2-7-0
Review Comment:
```suggestion
# But the executors command is not available till airflow-2-7-0
```
##########
scripts/in_container/verify_providers.py:
##########
@@ -714,12 +714,17 @@ def run_provider_discovery():
subprocess.run(["airflow", "providers", "secrets"], check=True)
console.print("[bright_blue]List all auth backends[/]\n")
subprocess.run(["airflow", "providers", "auth"], check=True)
- if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.7.0.dev0"):
+ if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.6.0.dev0"):
# CI also check if our providers are installable and discoverable in airflow older versions
# But the triggers command is not available till airflow-2-6-0
# TODO: Remove this block once airflow dependency in providers are > 2-6-0
console.print("[bright_blue]List all triggers[/]\n")
subprocess.run(["airflow", "providers", "triggers"], check=True)
+ if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.7.0.dev0"):
+ # CI also check if our providers are installable and discoverable in airflow older versions
+ # But the triggers command is not available till airflow-2-7-0
Review Comment:
of course :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260686817
##########
airflow/executors/executor_loader.py:
##########
@@ -60,8 +60,9 @@ class ExecutorLoader:
LOCAL_EXECUTOR: "airflow.executors.local_executor.LocalExecutor",
LOCAL_KUBERNETES_EXECUTOR: "airflow.executors.local_kubernetes_executor.LocalKubernetesExecutor",
SEQUENTIAL_EXECUTOR: "airflow.executors.sequential_executor.SequentialExecutor",
- CELERY_EXECUTOR: "airflow.executors.celery_executor.CeleryExecutor",
- CELERY_KUBERNETES_EXECUTOR: "airflow.executors.celery_kubernetes_executor.CeleryKubernetesExecutor",
+ CELERY_EXECUTOR: "airflow.providers.celery.executors.celery_executor.CeleryExecutor",
+ CELERY_KUBERNETES_EXECUTOR: "airflow.providers.celery."
+ "executors.celery_kubernetes_executor.CeleryKubernetesExecutor",
Review Comment:
Difficult one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1261461649
##########
scripts/in_container/verify_providers.py:
##########
@@ -714,12 +714,17 @@ def run_provider_discovery():
subprocess.run(["airflow", "providers", "secrets"], check=True)
console.print("[bright_blue]List all auth backends[/]\n")
subprocess.run(["airflow", "providers", "auth"], check=True)
- if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.7.0.dev0"):
+ if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.6.0.dev0"):
# CI also check if our providers are installable and discoverable in airflow older versions
# But the triggers command is not available till airflow-2-6-0
# TODO: Remove this block once airflow dependency in providers are > 2-6-0
console.print("[bright_blue]List all triggers[/]\n")
subprocess.run(["airflow", "providers", "triggers"], check=True)
+ if packaging.version.parse(airflow.version.version) >= packaging.version.parse("2.7.0.dev0"):
+ # CI also check if our providers are installable and discoverable in airflow older versions
+ # But the triggers command is not available till airflow-2-7-0
Review Comment:
Copypasta?? "triggers command"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260380057
##########
airflow/providers/celery/executors/__init__.py:
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import packaging.version
+
+from airflow.exceptions import AirflowOptionalProviderFeatureException
+
+try:
+ from airflow import __version__ as airflow_version
+except ImportError:
+ from airflow.version import version as airflow_version
+
+base_version = packaging.version.parse(airflow_version).base_version
Review Comment:
Seems like you could just inline this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260378279
##########
airflow/executors/executor_loader.py:
##########
@@ -60,8 +60,9 @@ class ExecutorLoader:
LOCAL_EXECUTOR: "airflow.executors.local_executor.LocalExecutor",
LOCAL_KUBERNETES_EXECUTOR: "airflow.executors.local_kubernetes_executor.LocalKubernetesExecutor",
SEQUENTIAL_EXECUTOR: "airflow.executors.sequential_executor.SequentialExecutor",
- CELERY_EXECUTOR: "airflow.executors.celery_executor.CeleryExecutor",
- CELERY_KUBERNETES_EXECUTOR: "airflow.executors.celery_kubernetes_executor.CeleryKubernetesExecutor",
+ CELERY_EXECUTOR: "airflow.providers.celery.executors.celery_executor.CeleryExecutor",
+ CELERY_KUBERNETES_EXECUTOR: "airflow.providers.celery."
+ "executors.celery_kubernetes_executor.CeleryKubernetesExecutor",
Review Comment:
I know this is implicit concatenation, but don't we generally try to avoid that? Not sure what would be better here though, so feel free to just ignore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260376197
##########
airflow/cli/commands/provider_command.py:
##########
@@ -167,3 +167,15 @@ def auth_backend_list(args):
"api_auth_backand_module": x,
},
)
+
+
+@suppress_logs_and_warning
+def executors_list(args):
+ """Lists all secrets backends at the command line."""
Review Comment:
Copypasta
```suggestion
"""Lists all executors at the command line."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on code in PR #32532:
URL: https://github.com/apache/airflow/pull/32532#discussion_r1260495220
##########
airflow/providers_manager.py:
##########
@@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None:
if _sanity_check(provider_package, auth_backend_module_name + ".init_app", provider):
self._api_auth_backend_module_names.add(auth_backend_module_name)
Review Comment:
Of course, it's not as easy as it looks. I tried [this](https://github.com/aws-mwaa/upstream-to-airflow/commit/6ad3e78d0d7205cd1e63821c5087282ff66ac4c1) but it broke a couple dozen unit tests. Maybe not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32532: Add Executors discovery and documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32532:
URL: https://github.com/apache/airflow/pull/32532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org