You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Benchao Li (Jira)" <ji...@apache.org> on 2023/05/27 03:35:00 UTC

[jira] [Updated] (CALCITE-5727) RelOptFixture#checkUnchanged should assert planAfter is not present

     [ https://issues.apache.org/jira/browse/CALCITE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benchao Li updated CALCITE-5727:
--------------------------------
    Description: This is discovered while I'm review another [PR|https://github.com/apache/calcite/pull/3193#discussion_r1204998877]. And there are already some tests that using {{checkUnchanged}}, but the xml file still contains {{planAfter}} section, such as {{RelOptRulesTest#testNoReduceAverage}}.  (was: This is discovered while I'm review anther [PR|https://github.com/apache/calcite/pull/3193#discussion_r1204998877]. And there are already some tests that using {{checkUnchanged}}, but the xml file still contains that {{planAfter}} section, such as {{RelOptRulesTest#testNoReduceAverage}}.)

> RelOptFixture#checkUnchanged should assert planAfter is not present
> -------------------------------------------------------------------
>
>                 Key: CALCITE-5727
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5727
>             Project: Calcite
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 1.34.0
>            Reporter: Benchao Li
>            Assignee: Benchao Li
>            Priority: Minor
>             Fix For: 1.35.0
>
>
> This is discovered while I'm review another [PR|https://github.com/apache/calcite/pull/3193#discussion_r1204998877]. And there are already some tests that using {{checkUnchanged}}, but the xml file still contains {{planAfter}} section, such as {{RelOptRulesTest#testNoReduceAverage}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)