[jira] [Commented] (GORA-458) DataOutputStream is not closed in BinaryEncoder#encodeXXX() methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GORA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103992#comment-15103992 ] 

ASF GitHub Bot commented on GORA-458:
-------------------------------------

GitHub user renato2099 opened a pull request:

    https://github.com/apache/gora/pull/53

    GORA-458

    Closing streams in binaryEncoder.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/renato2099/gora GORA-458

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 1dfa86d255bea79a25afbc3402e12ecb8e29fd15
Author: Renato Marroquin <re...@gmail.com>
Date:   2016-01-17T23:36:53Z

    GORA-458

----


> DataOutputStream is not closed in BinaryEncoder#encodeXXX() methods
> -------------------------------------------------------------------
>
>                 Key: GORA-458
>                 URL: https://issues.apache.org/jira/browse/GORA-458
>             Project: Apache Gora
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> In ./gora-accumulo/src/main/java/org/apache/gora/accumulo/encoders/BinaryEncoder.java :
> {code}
>       DataOutputStream dos = new DataOutputStream(new FixedByteArrayOutputStream(ret));
>       dos.writeShort(s);
>       return ret;
> {code}
> dos should be closed before returning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)