You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2016/07/20 12:28:03 UTC

[GitHub] activemq-artemis pull request #648: Mqtt fix

GitHub user mtaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/648

    Mqtt fix

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mtaylor/activemq-artemis MQTTFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #648
    
----
commit 1f0caf3b832daf052b024b433802508a1623a3bb
Author: Martyn Taylor <mt...@redhat.com>
Date:   2016-07-19T16:08:10Z

    ARTEMIS-641 filter out management notifications in MQTT

commit 4fce562e0a605b2533e709fe7eaba6d71ea1837c
Author: Martyn Taylor <mt...@redhat.com>
Date:   2016-07-20T12:21:53Z

    ARTEMIS-641 Enable filtering on address in server consumer

commit 9a6dc47ffc081580a512641b198a15ee7315866c
Author: Martyn Taylor <mt...@redhat.com>
Date:   2016-07-20T12:24:09Z

    ARTEMIS-335 Remove dead code from MQTTPublishManager

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #648: Mqtt fix

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/648


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #648: Mqtt fix

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/648
  
    Leave this open for now, I'm going to do some rework based on @andytaylor feedback


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #648: Mqtt fix

Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/648
  
    test failures were env, I will merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #648: Mqtt fix

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/648
  
    @jbertram I think you've merged a very old version of this PR (hence why it's showing as open).  It looks like you merged the commits locally 2 days ago but pushed yesterday.  In between that time, I've added some changes.  I'll rebase the changes on master and send another PR.  I'm going to close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---