You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2018/04/12 19:59:42 UTC
[GitHub] nifi pull request #2633: NIFI-5066: Allow global enable/disable component re...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2633
NIFI-5066: Allow global enable/disable component requests
NIFI-5066:
- Allowing the enable/disable buttons to be active under the same conditions as the start/stop buttons.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-5066
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2633
----
commit 9acae4786cccc8823d5b0a45fb03f2639e9b16d7
Author: Matt Gilman <ma...@...>
Date: 2018-04-12T18:12:01Z
NIFI-5066:
- Allowing the enable/disable buttons to be active under the same conditions as the start/stop buttons.
----
---
[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2633
+1 for the UI code.
---
[GitHub] nifi pull request #2633: NIFI-5066: Allow global enable/disable component re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2633
---
[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2633
@andrewmlim When no components are selected both enable/disable and start/stop should be allowed as the request will be applied to all eligible components in the current process group.
---
[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2633
@mcgilman many thanks for adding this improvement. Code looks good. Was able to verify functionality and everything worked exactly as I expected. +1 merged to master.
---
[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests
Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim commented on the issue:
https://github.com/apache/nifi/pull/2633
Changes look good. Enable/disable and start/stop buttons behave consistently. This is minor, but it would be nice if all of these buttons were greyed out (or unavailable in the context menu) when there were no components available i.e. when the process group is empty.
---