You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Gert Vanthienen (JIRA)" <ji...@apache.org> on 2011/04/01 15:17:05 UTC

[jira] [Created] (SMX4NMR-265) Allow invoking an endpoint as the Subject passed along in the Message

Allow invoking an endpoint as the Subject passed along in the Message
---------------------------------------------------------------------

                 Key: SMX4NMR-265
                 URL: https://issues.apache.org/jira/browse/SMX4NMR-265
             Project: ServiceMix NMR
          Issue Type: Improvement
    Affects Versions: 1.4.0
            Reporter: Gert Vanthienen
            Assignee: Gert Vanthienen
             Fix For: 1.5.0


The NMR API allow for the Message to contain a SecuritySubject.  We should improve the NMR endpoint to (optionally) support being invoked on behalf of that Subject (using {{Subject.doAs(...)}}) so that any code inside the endpoint can easily access this information through the {{Subject.getSubject(...)}} method.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Commented] (SMX4NMR-265) Allow invoking an endpoint as the Subject passed along in the Message

Posted by Gert Vanthienen <ge...@gmail.com>.
L.S.,

As far as I know, the preferred way for now still is to attach a patch
to a JIRA issue.  That way, you can explicitly grant permission to the
ASF to include the patch in the codebase.  If you prefer git, feel
free to attach the output for git format-patch as well.

Regards,

Gert Vanthienen
------------------------
FuseSource
Web: http://fusesource.com
Blog: http://gertvanthienen.blogspot.com/



On Fri, Apr 1, 2011 at 10:35 PM, Kurt Westerfeld <kw...@novell.com> wrote:
> I'd be glad to submit patches I have before--is that the preferred mechanism or is there a way to do this with github that is more automated?
>
>>>> "Gert Vanthienen (JIRA)" <ji...@apache.org> 4/1/2011 4:01 PM >>>
>
>    [ https://issues.apache.org/jira/browse/SMX4NMR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014808#comment-13014808 ]
>
> Gert Vanthienen commented on SMX4NMR-265:
> -----------------------------------------
>
> Hey Kurt,
>
> That's a few excellent suggestions you have made there.  I've created a few follow-up issues SMX4-792 (for adding support to Camel NMR), SMX4-793 (for adding support to CXF NMR) and SMX4NMR-267 (for adding support to the JBI endpoints).
>
> Also, your suggestion for automatically picking up the Subject and injecting it into a Message being sent, has been added as SMX4NMR-266.
>
> (BTW, feel free to take a stab at any of these issues ;))
>
> Regards,
>
> Gert
>
>> Allow invoking an endpoint as the Subject passed along in the Message
>> ---------------------------------------------------------------------
>>
>>                 Key: SMX4NMR-265
>>                 URL: https://issues.apache.org/jira/browse/SMX4NMR-265
>>             Project: ServiceMix NMR
>>          Issue Type: Improvement
>>    Affects Versions: 1.4.0
>>            Reporter: Gert Vanthienen
>>            Assignee: Gert Vanthienen
>>             Fix For: 1.5.0
>>
>>
>> The NMR API allow for the Message to contain a SecuritySubject.  We should improve the NMR endpoint to (optionally) support being invoked on behalf of that Subject (using {{Subject.doAs(...)}}) so that any code inside the endpoint can easily access this information through the {{Subject.getSubject(...)}} method.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Re: [jira] [Commented] (SMX4NMR-265) Allow invoking an endpoint as the Subject passed along in the Message

Posted by Kurt Westerfeld <kw...@novell.com>.
I'd be glad to submit patches I have before--is that the preferred mechanism or is there a way to do this with github that is more automated?

>>> "Gert Vanthienen (JIRA)" <ji...@apache.org> 4/1/2011 4:01 PM >>>

    [ https://issues.apache.org/jira/browse/SMX4NMR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014808#comment-13014808 ] 

Gert Vanthienen commented on SMX4NMR-265:
-----------------------------------------

Hey Kurt,

That's a few excellent suggestions you have made there.  I've created a few follow-up issues SMX4-792 (for adding support to Camel NMR), SMX4-793 (for adding support to CXF NMR) and SMX4NMR-267 (for adding support to the JBI endpoints).

Also, your suggestion for automatically picking up the Subject and injecting it into a Message being sent, has been added as SMX4NMR-266.

(BTW, feel free to take a stab at any of these issues ;))

Regards,

Gert

> Allow invoking an endpoint as the Subject passed along in the Message
> ---------------------------------------------------------------------
>
>                 Key: SMX4NMR-265
>                 URL: https://issues.apache.org/jira/browse/SMX4NMR-265
>             Project: ServiceMix NMR
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>             Fix For: 1.5.0
>
>
> The NMR API allow for the Message to contain a SecuritySubject.  We should improve the NMR endpoint to (optionally) support being invoked on behalf of that Subject (using {{Subject.doAs(...)}}) so that any code inside the endpoint can easily access this information through the {{Subject.getSubject(...)}} method.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SMX4NMR-265) Allow invoking an endpoint as the Subject passed along in the Message

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SMX4NMR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014808#comment-13014808 ] 

Gert Vanthienen commented on SMX4NMR-265:
-----------------------------------------

Hey Kurt,

That's a few excellent suggestions you have made there.  I've created a few follow-up issues SMX4-792 (for adding support to Camel NMR), SMX4-793 (for adding support to CXF NMR) and SMX4NMR-267 (for adding support to the JBI endpoints).

Also, your suggestion for automatically picking up the Subject and injecting it into a Message being sent, has been added as SMX4NMR-266.

(BTW, feel free to take a stab at any of these issues ;))

Regards,

Gert

> Allow invoking an endpoint as the Subject passed along in the Message
> ---------------------------------------------------------------------
>
>                 Key: SMX4NMR-265
>                 URL: https://issues.apache.org/jira/browse/SMX4NMR-265
>             Project: ServiceMix NMR
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>             Fix For: 1.5.0
>
>
> The NMR API allow for the Message to contain a SecuritySubject.  We should improve the NMR endpoint to (optionally) support being invoked on behalf of that Subject (using {{Subject.doAs(...)}}) so that any code inside the endpoint can easily access this information through the {{Subject.getSubject(...)}} method.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SMX4NMR-265) Allow invoking an endpoint as the Subject passed along in the Message

Posted by "Kurt Westerfeld (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SMX4NMR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014583#comment-13014583 ] 

Kurt Westerfeld commented on SMX4NMR-265:
-----------------------------------------

I love this change as it it obviates the need for the java-side code to worry about using JBIContext when using servicemix-cxf-se.  Can we easily setup those types of endpoints using OSGi metadata or similar as being "subject aware"?  It wasn't obvious how to make the adjustment from the new constants in endpoint.  

On the sender side, if one does an invocation within a Subject.doAs(), it would be similarly awesome of cxfse:proxy would lookup such a Subject within a context to propagate to outbound endpoints. Just need to be sure to check if there is an access control context as Subject.getSubject() will throw an NPE if you blindly pass AccessController.getContext() through.

I made a patch to cxfse:proxy which does something along the lines of lookup of the subject from JBIContext in this case, but it would be more appropriate to additionally lookup the current subject context in this way.

> Allow invoking an endpoint as the Subject passed along in the Message
> ---------------------------------------------------------------------
>
>                 Key: SMX4NMR-265
>                 URL: https://issues.apache.org/jira/browse/SMX4NMR-265
>             Project: ServiceMix NMR
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>             Fix For: 1.5.0
>
>
> The NMR API allow for the Message to contain a SecuritySubject.  We should improve the NMR endpoint to (optionally) support being invoked on behalf of that Subject (using {{Subject.doAs(...)}}) so that any code inside the endpoint can easily access this information through the {{Subject.getSubject(...)}} method.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SMX4NMR-265) Allow invoking an endpoint as the Subject passed along in the Message

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SMX4NMR-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gert Vanthienen resolved SMX4NMR-265.
-------------------------------------

    Resolution: Fixed

Fixed in http://svn.apache.org/viewvc?view=revision&revision=1087697

> Allow invoking an endpoint as the Subject passed along in the Message
> ---------------------------------------------------------------------
>
>                 Key: SMX4NMR-265
>                 URL: https://issues.apache.org/jira/browse/SMX4NMR-265
>             Project: ServiceMix NMR
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Gert Vanthienen
>            Assignee: Gert Vanthienen
>             Fix For: 1.5.0
>
>
> The NMR API allow for the Message to contain a SecuritySubject.  We should improve the NMR endpoint to (optionally) support being invoked on behalf of that Subject (using {{Subject.doAs(...)}}) so that any code inside the endpoint can easily access this information through the {{Subject.getSubject(...)}} method.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira