You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/13 07:29:06 UTC

[GitHub] [arrow-datafusion] Ted-Jiang opened a new pull request, #2726: [Minor] add debug info in optimizer.rs

Ted-Jiang opened a new pull request, #2726:
URL: https://github.com/apache/arrow-datafusion/pull/2726

   # Which issue does this PR close?
   it's better output which rule is running in debug log.
   
   Closes #.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] waynexia commented on pull request #2726: [Minor] add debug info in optimizer.rs

Posted by GitBox <gi...@apache.org>.
waynexia commented on PR #2726:
URL: https://github.com/apache/arrow-datafusion/pull/2726#issuecomment-1153833559

   These logs are useful to me. They are exactly what I add when debugging #2712 🤣 (some panicking rules cannot benefit from `EXPLAIN`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #2726: [Minor] add debug info in optimizer.rs

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2726:
URL: https://github.com/apache/arrow-datafusion/pull/2726#issuecomment-1155016570

   Makes sense -- I just wanted to point out the EXPLAIN VERBOSE thing too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #2726: [Minor] add debug info in optimizer.rs

Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on PR #2726:
URL: https://github.com/apache/arrow-datafusion/pull/2726#issuecomment-1154638607

   > Thanks @Ted-Jiang
   > 
   > You probably know it, but you can also use `EXPLAIN VERBOSE` to see the output of the plans after each pass
   > 
   > For example:
   > 
   > ```sql
   > EXPLAIN VERBOSE SELECT * from foo where x > 5
   > ```
   
   @alamb Thanks a lot for your kindly advice! Like @waynexia  said, our team send logical plan to datafusion, it's easy to debug in this way.(Not want change our code 😂)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb merged pull request #2726: [Minor] add debug info in optimizer.rs

Posted by GitBox <gi...@apache.org>.
alamb merged PR #2726:
URL: https://github.com/apache/arrow-datafusion/pull/2726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Ted-Jiang closed pull request #2726: [Minor] add debug info in optimizer.rs

Posted by GitBox <gi...@apache.org>.
Ted-Jiang closed pull request #2726: [Minor] add debug info in optimizer.rs
URL: https://github.com/apache/arrow-datafusion/pull/2726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org