You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/01/31 01:50:31 UTC
Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
Diffs
-----
src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
Diff: https://reviews.apache.org/r/17572/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/#review33999
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Feb. 6, 2014, 1:45 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17572/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 1:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
> src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
>
> Diff: https://reviews.apache.org/r/17572/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/
-----------------------------------------------------------
(Updated Feb. 11, 2014, 7:12 a.m.)
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
Changes
-------
rebased. NNFR.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
Diffs (updated)
-----
src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
Diff: https://reviews.apache.org/r/17572/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 9:45 p.m.)
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
Changes
-------
comments.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
Diffs (updated)
-----
src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
Diff: https://reviews.apache.org/r/17572/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/#review33278
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 30, 2014, 4:50 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17572/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 4:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
> src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
>
> Diff: https://reviews.apache.org/r/17572/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/#review33371
-----------------------------------------------------------
Ship it!
src/common/protobuf_utils.hpp
<https://reviews.apache.org/r/17572/#comment62830>
Any reason for the call above to use stringify, and this one to rely on the cast operator?
src/common/type_utils.hpp
<https://reviews.apache.org/r/17572/#comment62831>
These scare me a bit. Should we write a reflection-based equality operator, or do we want specialized equality semantics?
- Ben Mahler
On Jan. 31, 2014, 12:50 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17572/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 12:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
> src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
>
> Diff: https://reviews.apache.org/r/17572/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Vinod Kone <vi...@gmail.com>.
> On Feb. 1, 2014, 12:45 a.m., Benjamin Hindman wrote:
> > src/common/protobuf_utils.hpp, line 105
> > <https://reviews.apache.org/r/17572/diff/1/?file=457210#file457210line105>
> >
> > Do you want to add any more randomness here? the MasterInfo created right now in master.cpp has the date information. At the very least I think a comment here describing that you're putting in arbitrary stuff to make up the ID would be great rather than getting people to expect that the ID == the PID.
Appended random uuid bits to pid here. I can't remember why I had to make it non-random.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/#review33376
-----------------------------------------------------------
On Jan. 31, 2014, 12:50 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17572/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 12:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
> src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
>
> Diff: https://reviews.apache.org/r/17572/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/#review33376
-----------------------------------------------------------
src/common/protobuf_utils.hpp
<https://reviews.apache.org/r/17572/#comment62835>
Do you want to add any more randomness here? the MasterInfo created right now in master.cpp has the date information. At the very least I think a comment here describing that you're putting in arbitrary stuff to make up the ID would be great rather than getting people to expect that the ID == the PID.
- Benjamin Hindman
On Jan. 31, 2014, 12:50 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17572/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 12:50 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
> src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
>
> Diff: https://reviews.apache.org/r/17572/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Feb. 3, 2014, 11:01 a.m., Jiang Yan Xu wrote:
> > src/common/protobuf_utils.hpp, line 105
> > <https://reviews.apache.org/r/17572/diff/1/?file=457210#file457210line105>
> >
> > I'd like some randomness (here and in master.cpp) too, if a UUID is too long given that we already have the date info maybe part of For MESOS-422, if a master starts twice within a second the `id` would be the same.
> >
> > The weird part with date info and random bits is that each new detector (on master, slave, sched) now generates a different MasterInfo for the same old contender (which still puts PID in ZK) but I think this is acceptable because the new master will never use the arbitrarily created `MasterInfo::id` to get "itself" elected. For other uses only the `MasterInfo::pid` is looked at so the `id` doesn't matter.
Oh I see that getpid() is used in master.cpp to generate `id` so it is "random" and it's OK here.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/#review33466
-----------------------------------------------------------
On Jan. 30, 2014, 4:50 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17572/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 4:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
> src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
>
> Diff: https://reviews.apache.org/r/17572/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create
MasterInfo from UPID.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17572/#review33466
-----------------------------------------------------------
src/common/protobuf_utils.hpp
<https://reviews.apache.org/r/17572/#comment62901>
I'd like some randomness (here and in master.cpp) too, if a UUID is too long given that we already have the date info maybe part of For MESOS-422, if a master starts twice within a second the `id` would be the same.
The weird part with date info and random bits is that each new detector (on master, slave, sched) now generates a different MasterInfo for the same old contender (which still puts PID in ZK) but I think this is acceptable because the new master will never use the arbitrarily created `MasterInfo::id` to get "itself" elected. For other uses only the `MasterInfo::pid` is looked at so the `id` doesn't matter.
- Jiang Yan Xu
On Jan. 30, 2014, 4:50 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17572/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 4:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 2. 'createMasterInfo()' is used in the subsequent reviews.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245
> src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8
>
> Diff: https://reviews.apache.org/r/17572/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>