[GitHub] [kafka] jsancio commented on a diff in pull request #12856: KAFKA-14392: KRaft broker should set controller.socket.timeout.ms

[GitBox <gi...@apache.org>]

jsancio commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023111417


##########
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##########
@@ -211,7 +211,7 @@ class BrokerToControllerChannelManagerImpl(
         50,
         Selectable.USE_DEFAULT_BUFFER_SIZE,
         Selectable.USE_DEFAULT_BUFFER_SIZE,
-        config.requestTimeoutMs,
+        config.controllerSocketTimeoutMs,

Review Comment:
   I see. The broker is sending the correct request timeout to the controller but it is not being honor on the client side.



##########
config/kraft/broker.properties:
##########
@@ -53,6 +53,9 @@ controller.listener.names=CONTROLLER
 # Maps listener names to security protocols, the default is for them to be the same. See the config documentation for more details
 listener.security.protocol.map=CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT,SSL:SSL,SASL_PLAINTEXT:SASL_PLAINTEXT,SASL_SSL:SASL_SSL
 
+# The controller socket timeout should not exceed the broker session timeout being used by the controller
+controller.socket.timeout.ms=9000

Review Comment:
   This is the actual fix. Shouldn't Kafka change the default? This is a problem with every cluster if they don't change the controller socket timeout or the broker session timeout. Right now the default broker session timeout is 9 seconds while the socket timeout is 30 seconds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org